Git Product home page Git Product logo

Comments (5)

dirk-thomas avatar dirk-thomas commented on August 20, 2024

If a package only exports dependencies but doesn't have any libraries why would it need to set the LD_LIBRARY_PATH? The assumption is that the dependency has defined the LD_LIBRARY_PATH itself.

from ament_cmake.

clalancette avatar clalancette commented on August 20, 2024

I think there was a slight typo in @stonier initial comment. We were interested in whether LD_LIBRARY_PATH should get set when ament_export_interfaces(...) is called. We're not sure how ament_export_interfaces(...) and ament_export_libraries(...) are supposed to interact (if at all).

from ament_cmake.

stonier avatar stonier commented on August 20, 2024

Yes, indeed. Thanks @clalancette. Intended ament_export_interfaces and fixed appropriately in the description above.

from ament_cmake.

dirk-thomas avatar dirk-thomas commented on August 20, 2024

The problem should be fixed in #135. @stonier It would be great if you could confirm that it addresses your use case.

from ament_cmake.

dirk-thomas avatar dirk-thomas commented on August 20, 2024

@stonier I updated the patch in the referenced PR. You will have to change your code to actually pass the export name instead of the target as well as pass the new option added in the referenced PR. Please let me know if that works for your use case.

from ament_cmake.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.