Making pdfmake.js optional about amcharts5 HOT 2 OPEN

@nicolaric pdfmake is already optional, amCharts uses dynamic import() which will only load the file when you actually use it.

So if you never export to PDF, then the file will never be loaded, and so it will not have any performance penalty at all.

You can confirm this by using the Chrome / Firefox devtools (the Network tab).

So you don't have to worry about it, pdfmake will not increase the bundle size, and it won't hurt performance.

It has no impact at all on loading times.

However, if you really do want to avoid the file completely, then you will need to change your Webpack configuration to ignore those modules:

https://www.amcharts.com/docs/v4/getting-started/integrations/using-webpack/#Large_file_sizes

  externals: function (context, request, callback) {
    if (/xlsx|canvg|pdfmake/.test(request)) {
      return callback(null, "commonjs " + request);
    }
    callback();
  }

from amcharts5.

maybe this could help as well?
bpampuch/pdfmake#1374

from amcharts5.