Git Product home page Git Product logo

Comments (3)

joesken avatar joesken commented on June 14, 2024

I've done a bit more investigations on this and have narrowed it down a bit.

For the scenario (based on the example code above) where you go from Continent View to Worldview and then try to change the state via the "Change Labels" button the issue is in line 150 of amcharts3-react.js.

It is trying to access a key which the object does not have:

            if (updateArray(obj[key], x, y)) {
              didUpdate = true;
            }

This was easily fixed by checking obj.hasOwnProperty(key)).

The second scenario is in the same area but a different issue. Under the scenario of going from Worldview to Country view and then updating the state the issue arises when setting the key for 'images'. The object is undefined. However it is an array of objects and the comparison on line 144 if (x !== y) is failing. (They are the same). Thus if this check was working correctly then it would never get to call updateArray(obj..).

Hope this helps.

Joe

from amcharts3-react.

Pauan avatar Pauan commented on June 14, 2024

@AaronONeill Thanks for reporting this!

@joesken Thanks for the detailed information!

I'll look into fixing this ASAP.

from amcharts3-react.

Pauan avatar Pauan commented on June 14, 2024

@AaronONeill Sorry for the wait, I have fixed this in version 2.0.3

from amcharts3-react.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.