Model to schema naming conventions about granite HOT 8 CLOSED

@eliasjpr As it stands with Granite, a fair amount of inflection assumptions are made in macros. I think relationships will need a major rewrite out of macro land before any real inflection library can be used. In the interim, I think fully configurable associations such as #103 is a workable solution.

from granite.

I agree, we should change this.

We should also look at adding a pluralize helper since adding an s is not ideal. we should just add a couple rules like if the word ends with an s, ch, sh then add es. However, we shouldn't go overboard on this and add a custom dictionary of words. It should be a straightforward predictable algorithm.

from granite.

Regarding the snake case table names - I think that fix is easy:
Here: https://github.com/amberframework/granite-orm/blob/master/src/granite_orm/table.cr#L30

# Currently
{% name_space = @type.name.gsub(/::/, "_").downcase.id %}

# Change to
{% name_space = @type.name.gsub(/::/, "_").underscore.id %}

Regarding dealing with pluralization, I think leveraging an existing library is a good idea: https://github.com/mosop/string_inflection

from granite.

I’d second pulling in a proper inflector. There are undoubtedly times where pedantic inflection is mote confusing to the majority of people (eg Media, Data), but more often than not I appreciated the ease of Rails inflection. In other projects I’ve attempted to live with a cheaper solution and regretted it.

from granite.

There is a nice inflector created here https://github.com/luckyframework/lucky_inflector

from granite.

Also crecto has a nice query syntax 👉 https://github.com/Crecto/crecto#query-syntax Unrelated comment 😅

from granite.

@robacarp I agree with you on #103

from granite.

Opening a new ticket #129 regarding the inflector

from granite.