Comments (22)
Will it be okay, if we do edge detection at the time of capturing the image only?
As in whenever the camera is used right, umm that would be ok i guess cause if we make use of crop for images thats uploaded from gallery there isnt a requirement for edge detection. Yeah that would do
from docscanner.
@Aman-zishan @Amitbhave Please try using the plugin on a real device. I have never tested the edge_detection plugin on the emulator.
from docscanner.
@Aman-zishan do you have anything in mind what should be used for edge detection?
For image crop, I was thinking to use image_cropper plugin.
from docscanner.
@Aman-zishan do you have anything in mind what should be used for edge detection?
For image crop, I was thinking to use image_cropper plugin.
There is edge detection plugin too, the problem is to split the logic into different processes and implement the idea. As of now the camera takes a pic and goes directly to share and print so we have to create a new preview screen which triggers for this edge detection and crop . This screen should also be triggered when users switch to greyscale or multi image capture/picker mode(which will be implemented later #11 and #10)
from docscanner.
Sure, can I work on this?
from docscanner.
Sure, can I work on this?
Are you implementing the same logic? Please do share a Screenshot while opening a PR too. Thank you!
from docscanner.
Will it be okay, if we do edge detection at the time of capturing the image only?
from docscanner.
There is this issue with edge_detection package.
sawankumarbundelkhandi/edge_detection#20
from docscanner.
There is this issue with edge_detection package.
sawankumarbundelkhandi/edge_detection#20
Did you try in a physical device?
Have you made a good amount of progress?. Then i guess we can open a new branch and work on this in that branch?. So we both can try and fix
I have created a new branch maybe you can PR to this branch so that i can look into it.
from docscanner.
Why do you need new branch? I have forked your repo.. While raising PR, I will attach screenshots as well don't worry.
from docscanner.
Oh cool then..i thought you were stuck at that error so we could work on it in that branch
from docscanner.
@Aman-zishan @Amitbhave Please try using the plugin on a real device. I have never tested the edge_detection plugin on the emulator.
Yeah saw a lot of issues with emulators while using this package.
from docscanner.
@Aman-zishan so should we be using this package or not as it doesn't work on emulator?
from docscanner.
@Aman-zishan so should we be using this package or not as it doesn't work on emulator?
I'm actually using a physical device. Can you use one too
from docscanner.
@Aman-zishan you can go ahead with this using actual physical device.
from docscanner.
?? what happened
from docscanner.
Actually I prefer to use emulator only for testing rather than using my own device.
from docscanner.
No problem
from docscanner.
Can I work on this? I am thinking of using this plugin. It is using opencv using dart:ffi.
The example there has an implementation of edge detection and crop.
Maybe we can add some filters as well, using this.
from docscanner.
Yes sure
from docscanner.
Hey @Prakhar314 , we have already implemented crop feature would be better if you work on edge detection
from docscanner.
I'm sorry, I won't be able to work on this any time soon.
from docscanner.
Related Issues (20)
- Take multiple images and merge to single pdf HOT 4
- Add feature -> Convert scanned image to greyscale mode
- Add feature -> upload image from gallery HOT 10
- Release updation HOT 21
- Hacktoberfest -> Stickers for contributors! HOT 2
- Enhancement -> camera preview HOT 1
- android.hardware.camera2.CameraAccessException: CAMERA_ERROR (3): The camera device has encountered a serious error HOT 2
- Feature -> Crop images HOT 2
- Generation of pdf fails in some of the physical devices
- Enhancement -> Add mediaQuery to grid view HOT 8
- Bug -> generating pdf HOT 1
- Remove extra white space in result pdf
- [Feature] OCR HOT 9
- Screenshots for F-Droid
- Bug: two pages showing up in pdf while choosing "print document" HOT 16
- Suggestion: Increase PDF compression HOT 4
- Is this project abundant? HOT 2
- Update to latest flutter version
- Hacktoberfest Contributions HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from docscanner.