Git Product home page Git Product logo

Comments (6)

octacode avatar octacode commented on August 20, 2024

@csoni111 thanks for reporting the bugs. Please go ahead.
However I remember solving the first bug I guess I did something bad while Resolving merge conflicts.
What I did was that I called the closeSearch() function in the ItemClick:-
https://gist.github.com/octacode/d014f1a02a9208fc9d657732a74a289f
Here and yes replacing the images with a single Drawable is really an awesome Idea. It'd help reduce the size.

from android.

csoni111 avatar csoni111 commented on August 20, 2024

This helps! Also I have some other code changes in mind to further improve the search functionality. Will make a pr for all those.

from android.

doomers avatar doomers commented on August 20, 2024

@csoni111 see #30 @lakshyagupta21 is already working on it, the Vector Drawable part

from android.

csoni111 avatar csoni111 commented on August 20, 2024

Yes I know that, I will just update the search icon that has been added recently. He might not have pulled this change.

from android.

doomers avatar doomers commented on August 20, 2024

Okay.

from android.

csoni111 avatar csoni111 commented on August 20, 2024

@octacode I have made the pr. Please review it if possible!

from android.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.