Comments (4)
This seems like a much cleaner solution, but I'm still weary of making fileURL optional, as several features of the library depend on them, for example the print and activity sheet. If this were to be optional, how would we handle these buttons/actions, and how would this get communicated to the user of the library, especially at the point of initialization?
from ios-pdf-reader.
I guess I am looking at it from a flexibility standpoint. It would allow consumers to use the project with a more flexible set of PDF sources, similar to vfr reader supports. We could handle the button behavior via documentation, examples, and asserts.
Happy to put together all of the above so it is clear to the developers using the project.
from ios-pdf-reader.
My main concern is making it clear to users what features/customizations are available when. If we can add the flexibility of a protocol oriented approach and not compromise on clarity and ease-of-use for developers using the project, I think we're golden. I'd be happy to take a look at a pull request.
from ios-pdf-reader.
Closing due to inactivity. Free free to re-open if you want to open up a pull request for this in the future.
from ios-pdf-reader.
Related Issues (20)
- Not building in Swift 4.2
- How to add pdf to UIView, not pushViewController? HOT 2
- Reason: image not found
- PDF anchor
- Draw lines on PDF file
- How to disable download / copy / print options dialog HOT 2
- How can i open web link in pdf viewer?
- Setting Header for remote url
- How to get last opened page HOT 1
- start page index from 1 not 0
- not support RTL and issue when tap to hide nav.
- isNavigationBarHidden in UITabBarController
- Flashing Links HOT 2
- When using CoreGraphics to draw in background thread memory usage of the app is getting very high until the App eventually crashes HOT 1
- Help - Share PDF other apps , with iOS9 HOT 1
- Newer version required Swift 5 HOT 3
- Some page of PDF render incompleted
- iOS9 cpu 100% HOT 6
- Some PDFs display blank white page HOT 3
- How can i display base64 string
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ios-pdf-reader.