Comments (7)
I merged a fix for it for now, reckon i need to see over PR permissions or something so others can contribute more easily. Assuming this fixes it and closing the issue.
Thanks guys! :)
from gitu.
This looks like a cryptic message from libgit2.
What does it say when you
RUST_BACKTRACE=1 cargo run
?
from gitu.
Seems to get the same output..
from gitu.
Been on rustc 1.76 (stable), switched to 1.78 (nightly) and I got these warnings as well. But I don't experience the same issue on Fedora.
Should add some logging options to Gitu. Best I can do here is guess.
Thank you for reporting it!
from gitu.
I've been banging away at this, and the problem is that Duration::MAX
is too large for the select(2)
syscall timeout value (at least on macOS). select()
gets called in the main loop via event::poll
:
Lines 218 to 226 in 9d60124
I think that this call to event::poll()
is unnecessary, because giving it a maximum, effectively infinite timeout, makes it blocking, just like event::read()
. Can the main loop just omit the if (poll) then continue
condition and block on event::read()
(delete lines 219-222)? I don't see any work that is currently being performed between calls to poll
, anyway.
Note: I found that the syscall call was the source of the problem by stepping through with a debugger, and I figured out the maximum value for the timeout to select(2)
on macOS with the following sloppy C code: https://gist.github.com/overhacked/0b041af7994c06f9b6837876083deb72
from gitu.
I meant to add, commenting out
if !event::poll(std::time::Duration::MAX)? {
continue;
}
gets rid of the error, and everything else in the TUI seems to work fine.
from gitu.
Agreed it looks entirely unnecessary. There's no need to draw unless there's an event. 👍
from gitu.
Related Issues (20)
- Log graph
- Log authors
- Disable/enable push ops depending on whether the HEAD is detached or not.
- [Bug] incorrect diff if file uses CRLF line endings HOT 3
- did 0.19.2 get re-tagged? HOT 2
- error compiling version 20.1 HOT 6
- [Feature Request] Not to show files listed in `.git/info/exclude` HOT 7
- Vim hangs when opening from gitu on Windows HOT 8
- building with flake failed
- Thank you! HOT 1
- Leading tabs not displayed in diffs HOT 2
- Compile error on Windows HOT 1
- Add to winget-pkgs
- option to change bar character for non-nerd fonts HOT 3
- Linux: invalid data in index - calculated checksum does not match expected HOT 2
- Getting "Standard input is not a terminal" with nano
- [Feature request] Support renamed' status for a file that have been moved/renamed via 'git mv'
- [Feature request] Support "renamed" status for a file that have been moved/renamed via "git mv
- [Feature request] Support "renamed" status for a file that have been moved/renamed via "git mv" HOT 5
- Autostash when doing instant fixup
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gitu.