Git Product home page Git Product logo

Comments (4)

andrcuns avatar andrcuns commented on July 17, 2024

Thanks for the issue. Sounds reasonable! Though I do think if using time travel helpers, you should make sure time is restored, I believe this formatter might not be the only one that get's affected by such issues 😄

from allure-ruby.

bibendi avatar bibendi commented on July 17, 2024

you should make sure time is restored

Definitely! We have already fixed them :)

from allure-ruby.

andrcuns avatar andrcuns commented on July 17, 2024

I read through the article and it actually seems, that monotonic clock is not very useful in this situation. We don't need to get elapsed time but rather epoch timestamp.

There is a constant that allows to do that, CLOCK_REALTIME, but even ruby documentation suggest to use Time.now over it.

from allure-ruby.

andrcuns avatar andrcuns commented on July 17, 2024

Closing this, it doesn't seem that monotonic clock is at all usable in scenario when one needs to get current epoch timestamp.

Given that Time.now happens in formatter which always happens outside of rspec context, I consider that users should make sure to reset time traveling in the scenario.

from allure-ruby.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.