Git Product home page Git Product logo

Comments (8)

sboisvert avatar sboisvert commented on July 19, 2024

(just a note, I think meta_key might need to be defined when doing orderby 'meta_value_num' to determine which meta_value to use when sorting.)

from es-wp-query.

mboynes avatar mboynes commented on July 19, 2024

A patch would be much appreciated 👍. The meta query might need a larger update to bring it up to speed with the latest in core, so if it seems like this is easier said than done and starts to turn into that, let me know and we can collaborate on the larger overhaul.

from es-wp-query.

mboynes avatar mboynes commented on July 19, 2024

Quick update here: I'm currently working on this issue and am hoping to have a PR ready today or tomorrow

from es-wp-query.

mboynes avatar mboynes commented on July 19, 2024

@sboisvert can you (or someone on your team) code review that? ^

from es-wp-query.

sboisvert avatar sboisvert commented on July 19, 2024

Looks good by me. @philipjohn Do you have any concerns with putting this as the RC release on production?

from es-wp-query.

mboynes avatar mboynes commented on July 19, 2024

After speaking with @gibrown and @xyu, we decided to create multiple versions of ES_WP_Query to support different ES versions (See #37). @sboisvert, VIP will need to use the master-1.x branch (I'll make it an official release once I get #35 and #36 merged).

from es-wp-query.

philipjohn avatar philipjohn commented on July 19, 2024

Yep, let's make this our RC.

from es-wp-query.

sboisvert avatar sboisvert commented on July 19, 2024

Okay pulling master 1.x and pushing it to RC plugins

from es-wp-query.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.