Git Product home page Git Product logo

Comments (6)

schmmd avatar schmmd commented on May 16, 2024

@matt-gardner what do you mean exactly by evaluate? allennlp/run evaluate or a particular method? Why do you need the ability to override here?

from allennlp.

matt-gardner avatar matt-gardner commented on May 16, 2024

Yeah, I meant the command. See #246 for the original motivation for this. Not really sure how necessary this is anymore... (The whole _sanitize_config() method can probably be removed at this point, actually.) I haven't recently run into a situation where I really wished I had this. I know @OyvindTafjord ran into it a lot more frequently, though.

from allennlp.

schmmd avatar schmmd commented on May 16, 2024

My WIP change #402 support overriding fields, but does not support removing fields.

from allennlp.

matt-gardner avatar matt-gardner commented on May 16, 2024

But that parameter was removed a long time ago, so that particular use case is no longer present. You could also override it with None to effectively remove it (which means you should probably do something like our replace_none method in your override code).

from allennlp.

schmmd avatar schmmd commented on May 16, 2024

The original motivation for this issue is moot.

from allennlp.

matt-gardner avatar matt-gardner commented on May 16, 2024

I just talked with Oyvind, and he brought up a few cases where being able to change test-time configuration is helpful, and is currently a huge pain.

  • Changing the batch size, because, e.g., the test data has some really long sentences
  • Trying hacks with padding, like what Oyvind did to the character CNN in BiDAF

These cases are pretty rare, though. We may want to open this issue again at some point in the future, but for now there's not enough motivation for it.

from allennlp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.