When to update contributor list about all-contributors HOT 3 CLOSED

Hi @mpeyper!

No guidelines. But I generally ask the contributor to add themselves as part of the PR or immediately after it's merged. I don't often keep the list up to date myself and instead leave it up to the contributors to add themselves.

Would you like to add something to the README for a suggestion on how to manage this?

from all-contributors.

Thanks @kentcdodds.

My feeling is that it is easy for a contributor to add themselves if they are actively changing the repo (i.e. through a PR), but this is much more difficult if they are contributing to the community without actually committing (e.g. reporting bugs, answering questions on SO, or doing talks/presentations).

Of course, anyone is welcome to submit a PR adding themselves or others to the list, but I think some users may not consider themselves as contributing without a commit, despite what the README declares a contributor to be. I would hate for these contributors to be missed.

In reality, it will be impossible to catch every case of missed contributor, especially those not on github. I wonder if the work on #18 and #58 could help in this respect?

Would you like to add something to the README for a suggestion on how to manage this?

I'm happy to add something once I've figured it out. 😄

from all-contributors.

Yes, for those situations I just add them as soon as I'm able. Definitely not a hard and fast rule there 🤷‍♂️

from all-contributors.