Counting Cronjobs Seems Incorrect about automaticactionux HOT 14 CLOSED

I'll take a look tomorrow.

edit: this week, just haven't had the chance just yet.

from automaticactionux.

@creecros could you kindly shed any light on this?

from automaticactionux.

thanks for the update

from automaticactionux.

remove the + 1
$systemTriggerCounter = $this->text->contains($action['event_name'], 'task.cronjob.daily') ;

and it works just fine now.

from automaticactionux.

Also, that said:

This line is an issue if there are no actions. Since $systemTriggerCounter is undefined if it does not go through the for each loop. Just define it before the loop somewhere, i.e. $systemTriggerCounter = 0; or conditionally prevent this line and any others that have these undefined variables if there are no actions.

from automaticactionux.

And you also need to remove the +1 here:

from automaticactionux.

@creecros ok perfect thanks so much for that, I will make the changes shortly.

I added you to my glancer plugin... hoping you could help with the comment id search function pretty pretty please

from automaticactionux.

remove the + 1 $systemTriggerCounter = $this->text->contains($action['event_name'], 'task.cronjob.daily') ;

and it works just fine now.

I applied your changes, still doesnt work on my side.... i got 2 background jobs and it counts total as one... the final count is correct, just the user/cron split seems weird

from automaticactionux.

Reopened as it still doesnt count the cronjobs right, but you can see the changes i made now in the commit

from automaticactionux.

hmm, worked perfect for me, ill take another look sometime this week. too late for me now.

from automaticactionux.

hmm, worked perfect for me, ill take another look sometime this week. too late for me now.

yeh cool, thanks alot...

from automaticactionux.

So ya, Test project 1 is fine, but Test project 2 is off...
https://www.nachostudio.ml/dashboard

from automaticactionux.

oh...duh.

$this->text->contains is a boolean.

from automaticactionux.

oh...duh.

$this->text->contains is a boolean.

ok i missed that from the countless snippets, howtos and tutorials i go through lol.... but thanks for this fix also!

from automaticactionux.