Problem with trailing space in the description of a service about alignak HOT 7 CLOSED

writing a test case triggering the problem should be rather easy..

gonna give it a try..

from alignak.

Ok I could rather easily reproduce the problem in a test case.

from alignak.

@flaf,

I've a fix ready but I'm not sure it's enough about your described problem (it does fix the testcase I've though),

from where come your $(val1)$ and $(val2)$ in your config extract ?

from alignak.

from where come your $(val1)$ and $(val2)$ in your config extract ?

said nothing, this is all from here : http://shinken.readthedocs.org/en/latest/08_configobjects/service.html

"relevant" extract :

duplicate_foreach
This is used to generate serveral service with only one service declaration. 
Shinken understands this statement as : “Create a service for earch key in the variable”. 
Usually, this statement come with a “$KEY$” string in the service_description
 (to have a differente name) and in the check_command (you want also a 
different check) Moreover, one or several variables can be associated to each key. Then, 
values can be used in the service definition with $VALUE$ or $VALUEn$ macros.

define host {
  host_name    linux-server
  ...
  _partitions   var $(/var)$, root $(/)$
  _openvpns   vpn1 $(tun1)$$(10.8.0.1)$, vpn2 $(tun2)$$(192.168.3.254)$
  ...
}

define service{
       host_name               linux-server
       service_description     disk-$KEY$
       check_command           check_disk!$VALUE$
       ...
       duplicate_foreach       _partitions
}

I confirm I'm on a fix.. (it takes a bit longuer than my initial "easy" fix 'cause I'm going to rewrite most of the main functions involved in this "duplicate foreach" particular use case 'cause they're mostly bad (in their form and content).

from alignak.

If by any chance you still have no fix for that, you can have a look on Shinken side. It is supposed to be fixed. The fix is adding \s in regexp basically.

from alignak.

Seen that. But i'm doing more actually. Code smells, more problems than the one mentionned hère.

from alignak.

👍

from alignak.