Making Photon work with GC about photonlibos HOT 10 CLOSED

@medvednikov @joe-conigliaro BTW, the threading part of photon now supports Windows via mingw (msys2). See https://github.com/alibaba/PhotonLibOS/pull/185/files#diff-f0db3c6fae5cc5fe519ada39d68af66b8c177096a3ee36c0d92893be964cf34c details.

from photonlibos.

Porting directives:

https://github.com/ivmai/bdwgc/blob/master/docs/porting.md#thread-support

from photonlibos.

@medvednikov take look at this

from photonlibos.

Great, thanks! Will do.

from photonlibos.

Hey,

Just wanted to give you an update.

We managed to successfully make Photon work in V with the Boehm GC by using the recently introduced set_photon_thread_stack_allocator.

The change turned out to be very simple:
vlang/v@9604a3f

So thanks a lot for that! This surely made Photon a great option for all GC languages.

from photonlibos.

@medvednikov

Glad to know it's working.

And I didn't expect that the allocator could be implemented in V. It's really cool!

from photonlibos.

@lihuiba Thanks for all the assistance. I was surprised how easy it was to add support (using the functions you provided).

Regarding the allocator, I did try using the default allocator and also the stackful_malloc function provided, however I kept getting segfaults.

our malloc uses the GC malloc (when GC is on), so Im guessing if we were to use another allocator we may need to provide some extra information to the GC as well as the roots. I'm not sure though, that is just a guess. Or perhaps I have to correct for page size when supplying the roots due to the alignment your allocator does.

from photonlibos.

@joe-conigliaro the stackful_malloc is intended for efficient context allocation in stackless coroutine, such as the one in C++20. It assumes a FILO order of allocation and deallocation. It is NOT a generic allocator.

from photonlibos.

Thanks for the reply @lihuiba, I had a feeling it was used for something like that due to the comment

from photonlibos.

Amazing news!

from photonlibos.