sortobject update (1.1.0) breaks webpack about react-element-to-jsx-string HOT 14 CLOSED

Thanks all!

from react-element-to-jsx-string.

Sortobject and editions author here.

You can always reach out besides deciding a mutiny.

The browser package.json field should be respected and used by browserify.

from react-element-to-jsx-string.

👍 I'm having the same issue this morning.

from react-element-to-jsx-string.

bevry/sortobject#3

from react-element-to-jsx-string.

👍 😄 Nice thanks to @balupton this is now fixed with version 1.1.1 of sortobject. Thanks to @dvkndn for opening the issue.

from react-element-to-jsx-string.

Sooo we can close this?

from react-element-to-jsx-string.

I'd say so. I don't have ability to.

from react-element-to-jsx-string.

Recently we tried to integrate this module into one of our services. editions makes an assumption that the javascript is in a node_modules directory and that you can require in the package.json. In our production environments we use browserify to bundle up our entire application into a single file for deployment, thus breaking the require statement here. Seems very similar to this issue.

We cannot remove this from our build process because the number of files in our node_modules caused us to run out of disk inodes on some of our prod machines and also made our deployments take MUCH longer. What would be your suggestion to use this module? Pin back the version?

Has there been any talk about not using sortobject/editions dependency since it is doing a pretty non-standard thing? I know shipping "fat" modules is cool these days, but node core will be figuring this out, soon hopefully, so adding a homegrown solution just for sorting of object keys seems like a bad idea for this module. Not criticizing, just asking :)

Commented on bevry/sortobject#7 as well (for reference).

from react-element-to-jsx-string.

I’m wondering if we could fix this in the react-element-to-jsx-string package itself by depending on sortobject/source/index.js directly. What do you think @vvo

from react-element-to-jsx-string.

To be honest, I cant see what the editions module is even doing for the sortobject package, seems like it just has that one version, right?

from react-element-to-jsx-string.

Good point. I was more suggesting it as a temporary workaround

from react-element-to-jsx-string.

Hey @balupton, sorry if it came across as mutiny, I didn't intend it as that at all! Not being familiar with that package and what it was doing I was just asking because it didn't appear to be doing anything. I could totally be wrong, thus my question about it only having one version. Also, I did comment on an issue on sortobject first :) bevry/sortobject#7

In this case, we are using browserify's --node flag to bundle for the node runtime. So it purposely ignores the browser field. Because the require is dynamic, browserify ignores it. Obviously we could add a forced require in our build for this package.json file, but that does not seem like a good idea. Any advice would be most welcome!

from react-element-to-jsx-string.

This seems like not an issue of our own package. Also I loved the

You can always reach out besides deciding a mutiny.

Because I thought

from react-element-to-jsx-string.

(Also please open new issues instead of reviving old ones, always easier)

from react-element-to-jsx-string.