Comments (14)
Thanks all!
from react-element-to-jsx-string.
Sortobject and editions author here.
You can always reach out besides deciding a mutiny.
The browser package.json field should be respected and used by browserify.
from react-element-to-jsx-string.
š I'm having the same issue this morning.
from react-element-to-jsx-string.
from react-element-to-jsx-string.
š š Nice thanks to @balupton this is now fixed with version 1.1.1
of sortobject
. Thanks to @dvkndn for opening the issue.
from react-element-to-jsx-string.
Sooo we can close this?
from react-element-to-jsx-string.
I'd say so. I don't have ability to.
from react-element-to-jsx-string.
Recently we tried to integrate this module into one of our services. editions
makes an assumption that the javascript is in a node_modules
directory and that you can require in the package.json
. In our production environments we use browserify
to bundle up our entire application into a single file for deployment, thus breaking the require statement here. Seems very similar to this issue.
We cannot remove this from our build process because the number of files in our node_modules
caused us to run out of disk inodes on some of our prod machines and also made our deployments take MUCH longer. What would be your suggestion to use this module? Pin back the version?
Has there been any talk about not using sortobject
/editions
dependency since it is doing a pretty non-standard thing? I know shipping "fat" modules is cool these days, but node core will be figuring this out, soon hopefully, so adding a homegrown solution just for sorting of object keys seems like a bad idea for this module. Not criticizing, just asking :)
Commented on bevry/sortobject#7 as well (for reference).
from react-element-to-jsx-string.
Iām wondering if we could fix this in the react-element-to-jsx-string package itself by depending on sortobject/source/index.js
directly. What do you think @vvo
from react-element-to-jsx-string.
To be honest, I cant see what the editions module is even doing for the sortobject
package, seems like it just has that one version, right?
from react-element-to-jsx-string.
Good point. I was more suggesting it as a temporary workaround
from react-element-to-jsx-string.
Hey @balupton, sorry if it came across as mutiny, I didn't intend it as that at all! Not being familiar with that package and what it was doing I was just asking because it didn't appear to be doing anything. I could totally be wrong, thus my question about it only having one version. Also, I did comment on an issue on sortobject
first :) bevry/sortobject#7
In this case, we are using browserify's --node
flag to bundle for the node runtime. So it purposely ignores the browser
field. Because the require is dynamic, browserify ignores it. Obviously we could add a forced require in our build for this package.json
file, but that does not seem like a good idea. Any advice would be most welcome!
from react-element-to-jsx-string.
This seems like not an issue of our own package. Also I loved the
You can always reach out besides deciding a mutiny.
Because I thought
from react-element-to-jsx-string.
(Also please open new issues instead of reviving old ones, always easier)
from react-element-to-jsx-string.
Related Issues (20)
- Dependency Dashboard
- Release new version HOT 5
- Move this repository to a new home HOT 2
- The requested module 'react-is/index.js' does not provide an export named 'ForwardRef' HOT 10
- Crash with v14.3.3 and newer with Gatsby
- production jsx string not correct HOT 5
- 14.3.3 causes crashes in Storybook HOT 4
- Error isPlainObject is not a function HOT 3
- Update react peerDependencies for React 18 HOT 5
- `useBooleanShorthandSyntax` strip false values HOT 3
- Convert jsx-string back to react-element HOT 1
- Release new version with bumped dependencies
- 15.0.0 changes
- Vulnerability in json dependency
- rm'd
- No handling for Symbol-named JSX tags like React.StrictMode
- Add a tag for new version 15.0.1
- className not working?
- <Form.Item> in antd is converted incorrectly
- forwardRef do not convert correctly
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
š Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ššš
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ā¤ļø Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-element-to-jsx-string.