Git Product home page Git Product logo

Comments (5)

mdirkse avatar mdirkse commented on August 27, 2024 1

Hi, yeah, sorry for the radio silence, the code that showed this behavior hasn't been exercised in quite some time, so I'll close it for now and if I hit it again I'll post a more thorough reproducer.

from ureq.

jsha avatar jsha commented on August 27, 2024

Thanks for the report! It looks like cookies are only saved for the first request in a redirect chain:

save_cookies(&unit, &resp);

Will fix.

from ureq.

jsha avatar jsha commented on August 27, 2024

An update on the above: I misread the code, and cookies are in fact saved on redirects after the first. I wrote a unittest (#127) to verify. Probably something else is going on. Are you able to share a sample of your code that triggered this problem so I can further debug?

from ureq.

jsha avatar jsha commented on August 27, 2024

By the way, we had a bug until recently: #130. When multiple cookies were present, we would send multiple Cookie headers instead of just one. That could also explain this behavior, depending on whether multiple cookies were in use.

from ureq.

nico-abram avatar nico-abram commented on August 27, 2024

Can this be closed? AIUI this is fixed, and has had no response from @mdirkse in a long time

from ureq.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.