Comments (2)
This comes from that early ureq API was modelled on superagent, which is still my goto nodejs http client and somewhat of a hero for me in API design.
I think that's the wrong thing in most cases.
Is it? If we ask "what could the user possibly mean with this input?"
Philosophically both ureq (and now hreq), were and are driven by a feeling that in the rust community, sometimes correctness and strict adherence to spec overrides usability concerns in API design. The http crate is better now, but the correctness of hyper, where the http crate started, often shows in the API the user is exposed to.
A fast and correct HTTP implementation for Rust.
For example this method signature:
impl Request {
fn header(&self, key: &str) -> Option<&str> { … }
}
is no good if the overriding concern for the API is correctness. Not all correct header values can be represented as rust String
, which forces the use of Result
and/or an intermediary HeaderValue
.
But how often do we really encounter such headers in the wild?
I want ureq (and hreq) to be correct and on spec, I want to be able to handle such headers if I find them, but without forcing the user of the API to jump through hoops. Simple, rememberable and User first API (how I encapsulated these thoughts in a design goal).
This is the bigger picture of the absence of Result
, the synthetic http error, and why using a path as URL defaults to localhost.
In early ureq I did however lurch too far in the other direction, so in the same way I'm for reintroducing some Result
instead of synthetic http error, also the localhost-by-default decision is up for challenge.
from ureq.
Thanks for the additional background on the API design!
I think we can probably find a middle path, where we keep the API simple and also filter out some error cases, by deferring all errors until .do_call()
. We would accept any String in the constructor of Request, and do validation later. If .do_call()
finds that the URL is invalid, it would return a Response with the Error
field already set.
from ureq.
Related Issues (20)
- [Bug] In some case return empty "Content-Length" response header HOT 3
- Timeout not working when having packet losses HOT 1
- Support Multipart Forms HOT 1
- Timeout not always respected HOT 5
- Invalid transformation to http::Response<Vec<u8>> for non utf8 response bodies HOT 3
- Example of requesting a continuous stream HOT 1
- Timeout not taking in consideration TimeoutConnect HOT 2
- ureq 2.9.3 fails to compile with errors in `hoot` HOT 3
- `ureq` 2.9.3 compilation fails due to `hoot` requiring rustc 1.65 HOT 4
- Keep-alive is disabled when using SOCKS HOT 1
- Update requirement of `url=2.3.1` HOT 3
- hootbin is a required dependency HOT 2
- Stream panics in drop during test
- Redirect history not available HOT 2
- Add support for configuring default headers in AgentBuilder HOT 1
- Potential to modify ordering for IS_TEST in lib module HOT 1
- Change `send_json` `data` argument HOT 4
- Add `Error::as_response` HOT 3
- Middleware cannot modify query string parameters? HOT 2
- Decide what to do about rustls defaulting to aws-lc-rs instead of ring HOT 12
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ureq.