Git Product home page Git Product logo

Comments (4)

github-actions avatar github-actions commented on August 23, 2024

Thank you!! This is your first issue on this repo

from strapi-plugin-email-designer.

jpizzle34 avatar jpizzle34 commented on August 23, 2024

Looking closer at

const isValidEmail =
/^(([^<>()\[\]\\.,;:\s@"]+(\.[^<>()\[\]\\.,;:\s@"]+)*)|(".+"))@((\[[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}])|(([a-zA-Z\-0-9]+\.)+[a-zA-Z]{2,}))$/;

It seems like the regex test fails if '<' '>' are included.

Also is this regex test necessary? Isn't the email validation carried out by the underlying strapi email provider? After removing this regex test, I now get error messages from the aws ses email provider if the email is invalid, instead of an empty error message.

Let me know what you guys think.

PS: On the topic of regex validation of a RFC compliant email string:
https://stackoverflow.com/questions/201323/how-can-i-validate-an-email-address-using-a-regular-expression
The answer offers a more complete regex test but also implies how complex it can be to maintain.

from strapi-plugin-email-designer.

alexzaganelli avatar alexzaganelli commented on August 23, 2024

Thank you for your great contributions @jpizzle34 on #46 !!

@all-contributors please add @jpizzle34 for code.

from strapi-plugin-email-designer.

allcontributors avatar allcontributors commented on August 23, 2024

@alexzaganelli

I've put up a pull request to add @jpizzle34! 🎉

from strapi-plugin-email-designer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.