Git Product home page Git Product logo

Comments (6)

VivianSolide avatar VivianSolide commented on August 23, 2024 1

Hello @alexzaganelli

It works!
Thank you 👍

from strapi-plugin-email-designer.

creazy231 avatar creazy231 commented on August 23, 2024 1

Thank you @creazy231, we cannot use typeof deleteConfirmationModal === 'number' due in MongoDB the id is a string type. What I've actually done is check if !isNil(deleteConfirmationModal) && deleteConfirmationModal !== false. Should now work in both scenarios.

Awesome, and a nice fix 👍

from strapi-plugin-email-designer.

github-actions avatar github-actions commented on August 23, 2024

Thank you!! This is your first issue on this repo

from strapi-plugin-email-designer.

creazy231 avatar creazy231 commented on August 23, 2024

Hey Vivian,
thanks for reporting this issue. For now you can duplicate or delete your templates using EmailTemplates in your Collection Types. As an alternative you can use my fork at https://github.com/creazy231/strapi-plugin-email-designer of you don't use Mongo.

@alexzaganelli maybe we could use typeof deleteConfirmationModal === 'number' here https://github.com/alexzaganelli/strapi-plugin-email-designer/blob/main/admin/src/containers/HomePage/index.js#L216 and set the id like setDeleteConfirmationModal(+data.id) here https://github.com/alexzaganelli/strapi-plugin-email-designer/blob/main/admin/src/containers/HomePage/index.js#L277 to make it work using Mongo?

from strapi-plugin-email-designer.

VivianSolide avatar VivianSolide commented on August 23, 2024

Thanks for your answer.
I will manage to do it.

Cheers,
🍺

from strapi-plugin-email-designer.

alexzaganelli avatar alexzaganelli commented on August 23, 2024

Hi there,

Thank you so much for this plugin!
Nevertheless, I stumbled upon this issue:
image

I'm unable to delete or even duplicate a template.
And the console is empty.

Cheers,

Hi @VivianSolide thank you for interesting.
I've fixed this issue. Would be great if you can upgrade the email-designer and tell us if it now works.

Hey Vivian,
thanks for reporting this issue. For now you can duplicate or delete your templates using EmailTemplates in your Collection Types. As an alternative you can use my fork at https://github.com/creazy231/strapi-plugin-email-designer of you don't use Mongo.

@alexzaganelli maybe we could use typeof deleteConfirmationModal === 'number' here https://github.com/alexzaganelli/strapi-plugin-email-designer/blob/main/admin/src/containers/HomePage/index.js#L216 and set the id like setDeleteConfirmationModal(+data.id) here https://github.com/alexzaganelli/strapi-plugin-email-designer/blob/main/admin/src/containers/HomePage/index.js#L277 to make it work using Mongo?

Thank you @creazy231, we cannot use typeof deleteConfirmationModal === 'number' due in MongoDB the id is a string type. What I've actually done is check if !isNil(deleteConfirmationModal) && deleteConfirmationModal !== false. Should now work in both scenarios.

from strapi-plugin-email-designer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.