Git Product home page Git Product logo

Comments (5)

danielb2 avatar danielb2 commented on July 28, 2024

Documentation mentions protocol but I don't see it anywhere in the code. Looks like the http is hardcoded too.

https://github.com/alexrabarts/big_sitemap/blob/master/lib/big_sitemap.rb#L54

from big_sitemap.

rngtng avatar rngtng commented on July 28, 2024

use url_options: { host: "example.com", scheme: 'https' } and it should work. the hardcoded value is the default one .merge(..) overwrites it..

from big_sitemap.

danielb2 avatar danielb2 commented on July 28, 2024

You're right, so it does.

OK, so I'll leave this open to update the documentation to read scheme instead of protocol.

from big_sitemap.

danielb2 avatar danielb2 commented on July 28, 2024

And thanks 👍

from big_sitemap.

alexrabarts avatar alexrabarts commented on July 28, 2024

Thank you. The documentation is now fixed.

from big_sitemap.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.