Comments (3)
AlexPoint
commented on July 21, 2024
1
This is a good point!
I just fixed this behavior and published a new package (1.4.9) to nuget with this fix.
That must be one hell of a movie with subtitle items at more than 24 hours though! ;)
from subtitlesparser.
b-rad15
commented on July 21, 2024
This code here
should parse hour numbers greater than 24 fine. What was the timecode that gave you the -1 error?from subtitlesparser.
ElectiveRob
commented on July 21, 2024
file i used to test
WEBVTT
00:01.000 --> 00:04.000
Never drink liquid nitrogen.
00:05.000 --> 00:09.000
— It will perforate your stomach.
— You could die.
23:00:05.000 --> 23:59:59.999
— It will perforate your stomach.
— You could die.
24:00:00.000 --> 55:00:00.000
— It will perforate your stomach.
— You could die.See that 23:59:59.999 wil be parsed correctly
but 24:00:00.000 wil be -1
TimeSpan.TryParse doesn't seem to support the notation
from subtitlesparser.
Related Issues (20)
- Test could not pass
- Why are you targeting "netcoreapp2.1" instead of "netstandard2.0"? HOT 2
- Please remove all Console.WriteLine calls in the parsers HOT 1
- Tests fail on master HOT 2
- compatibility error HOT 8
- Parsing as srt returned no srt part HOT 2
- How can I get seconds instead of milliseconds? HOT 1
- Location data is lost in the WebVTT file HOT 1
- How to convert SRT to VTT or vice versa? HOT 1
- MicroDvd recognized as SRT HOT 6
- Updated NuGet HOT 2
- The decimal numbers of `StartTime` and `EndTime` of `SrtWriter` should be 3 instead of 2. HOT 1
- Parsing CSV type data with Split() has problems when 'Text' might contain commas HOT 2
- MIght want a way for SubParser to report which subtitle type it found HOT 3
- Stream is not in a valid Youtube XML format HOT 1
- Nuget Upgrade from 1.4.8 to 1.5.1 Failed
- The TextWriter writer should not be closed in the WriteStream method HOT 1
- Support for WebVTT writing HOT 1
- Support .NET Core HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from subtitlesparser.