Git Product home page Git Product logo

Comments (5)

timstrasser avatar timstrasser commented on July 30, 2024 1

Sounds great! I absolutely love the theme, just this single color needed a rework. :)

from vscode-a-touch-of-lilac-theme.

alexnho avatar alexnho commented on July 30, 2024

Hi @XENOTpro ,
Not really intended, the comments color was indeed updated from gray to green because with the gray the comments were a bit hard to read.
As for the screenshots, they are still the older ones as I didn't found time to redo and push them to the repo. I'll try to do it in the next period.

from vscode-a-touch-of-lilac-theme.

timstrasser avatar timstrasser commented on July 30, 2024

Hi @alexnho, personally I find the gray much more pleasant. I think this green is just too vibrant for this background color. Maybe a softer green (like #55945F) would be a better choice.
Personally I changed the color back to this blueish gray: #8091B3
I think this color is much more pleasant to the eye. ;)

from vscode-a-touch-of-lilac-theme.

alexnho avatar alexnho commented on July 30, 2024

Fair enough, I get why the green might be too visible for some people. :)
My idea with that vibrant green was that for the people that have the screen brightness on lower level (like me) will be also visible enough.
I promise that I'll look into changing it maybe to a better gray version (will give a try to the ones that you propose) in some future updates.

from vscode-a-touch-of-lilac-theme.

alexnho avatar alexnho commented on July 30, 2024

Thanks for the proposed blueish gray color @XENOTpro, I've gave it a try and liked it. :)
I've pushed the new comments styles to v1.2.1, based on the color I've also added some different shades to the comment to differentiate the elements inside them.
The comments look something like this:
comment_styles

Regards

from vscode-a-touch-of-lilac-theme.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.