Comments (8)
@weicheng113 I think same as you think. In my code, I am adding the following division.
p._grad = shared_grad_buffers.grads[n+'_grad']/params.num_processes
from pytorch-dppo.
@yusukeurakami Thanks for the reply. Do you mean you are going to add the averaging in this line -
Line 16 in ec93034
Or you have already added somewhere, which I did not find it. Thanks.
@yusukeurakami Sorry, I thought you were the author of the code. :) By the way, is the training working fine after you apply the division?
from pytorch-dppo.
@weicheng113 No problem. I replied to you because I was stacked at the same place. I don't have enough data points to compare the result yet, and I have to. I will update my result when I got it.
from pytorch-dppo.
@yusukeurakami Thanks a lot.
from pytorch-dppo.
@weicheng113 I've run my training with 7 workers in total. So, with average, gradients will be divided by 7 every update. however, from the result, both with average and non-average converged in the same values in almost same update steps. I don't really understand why it behaves same even the parameters were updated 7times smaller...
from pytorch-dppo.
@yusukeurakami Thanks for sharing good findings. I don't understand also. From gut feeling, the average will make update more steady with smaller steps. Could it be the env you are trying to solve is simple so that It cannot tell?
from pytorch-dppo.
@weicheng113 I am running a robot arm with 7 joints in continuous action and state space (original Mujoco environment). It should be complex enough.
from pytorch-dppo.
@yusukeurakami Ok, thanks.
from pytorch-dppo.
Related Issues (8)
- Old policy? HOT 5
- clamp ratio HOT 1
- Loss questions HOT 3
- on advantages HOT 1
- Failed in more complex environment HOT 1
- Question on algorithm itself HOT 2
- one of the variables needed for gradient computation has been modified by an inplace operation: [torch.FloatTensor [100, 1]], which is output 0 of TBackward, is at version 3; expected version 2 instead. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pytorch-dppo.