Git Product home page Git Product logo

Comments (3)

AlexCharlton avatar AlexCharlton commented on September 4, 2024

I'm not sure I see where you're coming from. with-init seems to me to be a pretty straight-forward solution to starting GLFW. If you are for some reason unsure about the scope of the program that will need to have GLFW initialized, sticking with-init at your program's entry point should be the solution. This way it shouldn't matter how many windows you want to have, and the structure seems crystal clear to me.

Still, I'm having trouble imagining what it is you created, so I'm curious to have a look. If you want to share the branch that has what you are working on, I can give you my thoughts.

from cl-glfw3.

jimrthy avatar jimrthy commented on September 4, 2024

Sometimes (?) I'm a moron. These changes crept in to that last patch, even though I meant to keep them separate.

It was just exporting initialize and terminate.

with-init is almost definitely the right approach in at least 99% of use cases. The more I think about mine (at the moment, that's kicking off windows into a separate thread from the repl), the more convinced I am that it's what I want here, too.

It's just that, for a little while, I thought it would make things a little less complicated to call terminate explicitly. The more I think about it, the more inclined I feel to agree with your original version: people probably don't really want to do this, so making it slightly more painful is probably a good hint that it's a bad idea.

I don't have any sort of real opinion either way. I'd close this now, except for the possibility that rolling those specific changes back out would probably be a slight improvement. Fewer obvious choices for newbs, without actually taking any options away from people who honestly have a valid reason for bypassing with-init.

from cl-glfw3.

AlexCharlton avatar AlexCharlton commented on September 4, 2024

Ah, yeah, I accepted that patch because it I didn't feel like it complicated the existing code any, so I was fine with it. Of course, there is something to be said for having one clear way of doing things, but I can't say I care enough to roll it back.

So consider this closed. In any case, thanks for your involvement!

from cl-glfw3.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.