Git Product home page Git Product logo

Comments (3)

alexbol99 avatar alexbol99 commented on July 30, 2024 2

You are right, this method was incomplete. Try new release v1.2.6, problem should be fixed.

from flatten-js.

alexbol99 avatar alexbol99 commented on July 30, 2024 1

Hello @bernizt ,
Sorry for the late reply.
I tried your example in the latest release (1.2.1) and got expected result in both cases.
See this notebook: https://observablehq.com/d/d407b9bed460e39b
Thanks,
Alex

from flatten-js.

karolis-k avatar karolis-k commented on July 30, 2024

I think there is still a bug. I updated the example, just changed the shape of polygon a little: https://observablehq.com/@karolis-k/issue-31-bug-in-polygon-contain-method
I quickly checked the code and it seems that the problem is that segment's/edge's inclusion is checked only by start, end and middle points. In previous example it just happened so by coincidence that middle point was outside polygon.

from flatten-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.