Git Product home page Git Product logo

Comments (5)

tsaxena avatar tsaxena commented on May 30, 2024

I also looked around and could not find support for groups in general. @alexandre01 Do we have to turn groups into simple paths for using the network?

from deepsvg.

pwichmann avatar pwichmann commented on May 30, 2024

As a workaround, you could create a script to automate Inkscape and apply it to your SVG input folder as a preprocessing step.
https://github.com/Klowner/inkscape-applytransforms

Have not tried it myself though.

from deepsvg.

tsaxena avatar tsaxena commented on May 30, 2024

Thanks @pwichmann . I will try that out.

For now, I figured out that the problem is NOT groups. I loaded an svg with groups and the current code base did load the svg correctly, except that I had to add "fill = "none" to each path in the group, otherwise when it draws its all black.
I am now trying to see if in that case the conversion to tensor is right. Is there a way of converting an tensor back to svg to make sure its working correctly?

from deepsvg.

alexandre01 avatar alexandre01 commented on May 30, 2024

Hello @tsaxena,

I recently added a Dataloader which can directly handle SVG icons as input. You can first pre-process the entire dataset using the https://github.com/alexandre01/deepsvg/blob/master/dataset/preprocess.py script or load https://github.com/alexandre01/deepsvg/blob/master/deepsvg/svg_dataset.py with already_preprocessed=False to perform preprocessing on the fly.

The preprocessing does the following:

svg.fill_(False)
svg.normalize().zoom(0.9)
svg.canonicalize()
svg = svg.simplify_heuristic()

Indeed, if you want to train a model for strokes only (without taking filling into account), you can set fill to False.

from deepsvg.

alexandre01 avatar alexandre01 commented on May 30, 2024

Let me just give some clarification regarding filling. Let's take the example of a filled "donut" shape: a filled circle with a "hole" inside. This is done in SVG by drawing in the same < path > a circular shape followed by another smaller circle drawn in the opposite direction (counter-clockwise). This is the even-odd rule.

DeepSVG however draws every path separately, and would generate in this case two paths. But how to apply the correct filling? The approach we propose is to predict a fill parameter which can take one of three values: Filling.OUTLINE (for stroke only), Filling.FILL (to fill the path) and Filling.ERASE (to "unfill" that area).

During preprocessing, paths are separated but the correct "fill" parameter is memorized. However, when visualising it, all filled shapes appear black.

The SVG.group_overlapping_paths method tackles this issue and re-maps the generated outputs to a valid SVG with even-odd fill rule. It does so by analysing overlaps between shapes and their fill parameters to group them together in a common path. This is a hack though, as this approach won't work for more complex cases.

It's therefore better to stick with strokes for the moment. Hope this helped.

from deepsvg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.