Git Product home page Git Product logo

Comments (8)

dblock avatar dblock commented on June 6, 2024

Without looking at the code I am going to guess it's a bug. We probably clear the response incorrectly in this case. Maybe try to write a test for this first, it should be fairly easy to fix.

from alexa-app.

dblock avatar dblock commented on June 6, 2024

@cpup22 Did you have better luck with the latest on HEAD (next 2.4.0 release)? Maybe try to build your scenario is a mocha test here?

from alexa-app.

cpup22 avatar cpup22 commented on June 6, 2024

I haven't tested again. I switched back from app-server to alexa-app only to try to pass certification. I changed my code to move back to alexa-app. I need to rebuilt the server environment again to test.

from alexa-app.

koyinusa avatar koyinusa commented on June 6, 2024

Am also having the same problem here.
After doing a return response.linkAccount() from pre()
The request still gets passed onto the intent

from alexa-app.

dblock avatar dblock commented on June 6, 2024

Please double check that you have the latest version and try to write a test for this, I am pretty sure it works as expected @koyinusa.

from alexa-app.

ericblade avatar ericblade commented on June 6, 2024

hmm.. what i use is

    response.linkAccount();
    throw new Error('Account Not Linked');

then my error handler looks like:

    app.error = (exception, request, response) => {
        const msg = exception.toString();
        if (msg === 'Error: Account Not Linked') {
            response.say('You need to link your account, please open the Alexa app to proceed.');
        } else {
            console.warn('Encountered error: ', msg);
        }
    }

am I doing it wrong?

from alexa-app.

koyinusa avatar koyinusa commented on June 6, 2024

@dblock I got it working by calling send. So my final working code looks like

response.linkAccount()
return response.say(statement).send()

You can also try this @ericblade. Instead of failing abruptly. You might instead return a statement that tells the user what they need to do, which in this case is to link their account

from alexa-app.

ericblade avatar ericblade commented on June 6, 2024

yeah.. it might make more sense if i threw the error, then responded in the error handler with both actions, instead of doing one of the actions above, then throwing the error, then responding with the other action... when i wrote that, life was insane, and i was barely able to think :-D

OTOH, even calling it an "Error" is kind of misleading, too. Usually I would treat Errors as more fatal .. but for some reason I decided to use it as a signaling mechanism there...

from alexa-app.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.