Alternate representation for Option<T> about ts-rs HOT 9 CLOSED

This is implemented (with a bit different approach) in #19.

from ts-rs.

Yes, this should be possible.
It's currently implemented this way since this is the default behaviour of serde.
However, as you corrently pointed out, the current implementation of TS doesn't allow for this.

A possible solution would be to define a TSConfig struct

struct TSConfig {
    treat_option_as_optional: bool
}

which would be passed to TS::name and TS::inline.

Then, the proc macro, which generates a TS implementation for your type, could parse a #[ts(treat_option_as_optional)] attribute and pass the according TSConfig instance to the calls.

Alternatively, this could just be solved by introducing a crate feature, and conditionally change the implementation of TS for Option<T: TS> depending of it, but I think it'd be nicer if this could be done on a per-struct and per-field basis.

If you feel like it, you could give it a try - the code is not super complicated, and I'm always happy to help.

from ts-rs.

Thanks for your fast reply @NyxCode ! I actually agree with you about the implementation on a per-struct / per-field basis.

I would really like to give a try (never played with macro so far), I'll definitely get back to you but it's probably not gonna be soon since I'm quite busy at the moment.

from ts-rs.

Do you mean passing treat_option_as_optional directly to both TS::name and TS::inline or there's a way to retrieve it from inside the functions without adding an additional parameter ?

from ts-rs.

Ping me on Discord if needed : Roms1383#0211

from ts-rs.

I thought about creating a struct like TSConfig and passing that to the functions.
That would make it easy to add additional attributes in the future.

from ts-rs.

Ah yes but when I was looking at it, it seems that it would have to be added in many many functions, am I correct?
I'd be up for a chat if you want!

from ts-rs.

p.s : I haven't yet pushed any changes on the fork because it's kinda messy at the moment (still logging stuff here and there to get familiar with your implementation and macro intricacies 😅)

from ts-rs.

sure, feel free to add me on discord. your ID is broken, i think the last digit is missing.

NyxCode#1137

from ts-rs.