Comments (6)
Is this a bug? What would be an example exploit?
Right now we only do the check when the validator is entering the committee. Afterwards, a validator can increase their self bond by smaller amounts than 100 credits.
The only transaction that lowers a validator balance is unbond_public
which is where we ensure the validator is still over the minimum 100 credit threshold, otherwise we remove them from the committee.
from snarkvm.
Is this a bug? What would be an example exploit?
Right now we only do the check when the validator is entering the committee. Afterwards, a validator can increase their self bond by smaller amounts than 100 credits.
The only transaction that lowers a validator balance is
unbond_public
which is where we ensure the validator is still over the minimum 100 credit threshold, otherwise we remove them from the committee.
Currently, the code only checks if the initial stake is greater than 100. For subsequent stakes, it is unable to execute the check for values greater than 100.
from snarkvm.
Would it need to execute the check for greater than 100 for subsequent stakes? The only thing that would lower the stake is unbond_public
which does the check to ensure the self bonded amount for a validator remains over 100.
from snarkvm.
Would it need to execute the check for greater than 100 for subsequent stakes? The only thing that would lower the stake is
unbond_public
which does the check to ensure the self bonded amount for a validator remains over 100.
Oh, I might have misunderstood. There is actually an initial requirement of 100 million (1,000,000,000,000) in the form of "gte r12 10_000_000_000_000u64 into r13;" for the first time. Here, the number 100 I mentioned earlier was mistakenly interpreted as the minimum staking requirement for validators each time.
from snarkvm.
That requirement is 10 million credits => 10_000_000_000_000u64
. Since the validator key is necessarily hot (live on a machine connected to the internet), we made the self bond amount small ~100 credits but the entire delegation is still 10M credits.
Another difference with this flow is that a validator can become unbonded by a delegator who by removing their stake can put the total delegation for a validator below 10M.
from snarkvm.
great
from snarkvm.
Related Issues (20)
- [Feature] Better UI for Users HOT 1
- Price in time-intensive finalize scopes HOT 5
- [Bug]rustc version
- [Bug]rusc version
- Optimizations to struct deserialization HOT 1
- [Feature] HOT 1
- [Bug] Aleo variable index array access HOT 1
- [Optimization] Inefficient fetching of `credits.aleo` PKs HOT 2
- Multiple crates missing `repository` field HOT 1
- [Bug] Truncated `ARCHOR_HEIGHT` leads to less `coinbase_reward` than expected HOT 5
- [Bug] No constant `BLOCK_TIME` with Bullshark HOT 6
- bug: incorrect timestamp in explorer HOT 1
- No need to create a credits with microcredits =0 HOT 2
- [Bug]Malicious validators can prevent legitimate transactions from being executed. HOT 6
- When you are going build with rust on Linux HOT 5
- [Bug] The delegator may fail to execute unbond_public
- Flaky Tests on CI HOT 3
- dependencies for a Rust project HOT 1
- [Bug] Incorrect `next_coinbase_target` update HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from snarkvm.