Comments (6)
deneonet
commented on June 30, 2024
Because it is reusing the buffer, it is used in a new benchmark, if it bothers you I can add a notice there.
from go_serialization_benchmarks.
ymz-ncnk
commented on June 30, 2024
No, it doesn't bother me. I'm just reminding that earlier a decision was made to remove all such code from separate benchmarks. And now we will start adding them again... Do you understand what I mean?
from go_serialization_benchmarks.
ymz-ncnk
commented on June 30, 2024
There was an open issue #106 and after it #107.
from go_serialization_benchmarks.
deneonet
commented on June 30, 2024
Okay, my bad. I remove the benchmark.
from go_serialization_benchmarks.
deneonet
commented on June 30, 2024
Heres the pull request: #131
from go_serialization_benchmarks.
alecthomas
commented on June 30, 2024
I'm actually not against pre-allocating buffers, but if we were to allow it it would have to be very clear which benchmarks were pre-allocated and which weren't.
Basically, I don't have an issue with any particular optimisations as long as it's very clear what they are and what the tradeoffs are.
from go_serialization_benchmarks.
Related Issues (20)
- Add benchmark for gjson
- Command, go get -u -t get error
- gob: unknown type id or corrupted data HOT 2
- Buffer Reuse Inconsistency HOT 1
- Skip running benchmarks for X if X fails to build HOT 4
- Gogoprotobuf Alternative? HOT 4
- How to test serializing a map?
- Limitations of the benchmarking HOT 2
- gogoprotobuf is deprecated
- Mus Strings HOT 24
- Bebop input data HOT 6
- BENC's unsafe code HOT 10
- supporting MarshalTap HOT 2
- New Link for readme HOT 1
- Idea: convert the root package to `main` HOT 3
- Idea: Switch from makefile to `go generate` instructions HOT 3
- Reopen #120 HOT 20
- Add Go Protobuf APIv2 tests
- Feature request: add benchmark for google protobuf
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go_serialization_benchmarks.