Git Product home page Git Product logo

Comments (6)

albertosottile avatar albertosottile commented on May 10, 2024 1

Thanks for narrowing this down. Could you try the code I just pushed in https://github.com/albertosottile/darkdetect/tree/cfunctype and check if it works on your M1 Mac?

EDIT: I did not realize you also had a fix to avoid passing None as third argument or change the other lines... I apologize if you still want to open a PR.

from darkdetect.

psobolewskiPhD avatar psobolewskiPhD commented on May 10, 2024 1

EDIT: I did not realize you also had a fix to avoid passing None as third argument or change the other lines... I apologize if you still want to open a PR.

It's not a problem! I was just hacking at it to see how/why. Your solution seems much more elegant!

from darkdetect.

albertosottile avatar albertosottile commented on May 10, 2024 1

Ok, I will then proceed with tests (for what I can run, though, as I still do not own a M1 Mac :( ) and release this fix as soon as possible.

Once again, thanks for finding and debugging this issue. I wonder how this code had worked with x86_64 up to now...

from darkdetect.

albertosottile avatar albertosottile commented on May 10, 2024 1

Fixed in 0.5.0.

from darkdetect.

psobolewskiPhD avatar psobolewskiPhD commented on May 10, 2024 1

Yup! And live on pip

Successfully installed darkdetect-0.5.0
╭─ ~ ···································································· ✔ ─╮
╰─ ipython                                                      (napari-test) ─╯
Python 3.9.7 | packaged by conda-forge | (default, Sep  2 2021, 17:55:16) 
Type 'copyright', 'credits' or 'license' for more information
IPython 7.25.0 -- An enhanced Interactive Python. Type '?' for help.

In [1]: import darkdetect

In [2]: darkdetect.theme()
Out[2]: 'Light'
<<<SWITCH TO DARK>>>
In [3]: darkdetect.theme()
Out[3]: 'Dark'

from darkdetect.

psobolewskiPhD avatar psobolewskiPhD commented on May 10, 2024

Works for both light and dark!

from darkdetect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.