Comments (6)
Thanks for narrowing this down. Could you try the code I just pushed in https://github.com/albertosottile/darkdetect/tree/cfunctype and check if it works on your M1 Mac?
EDIT: I did not realize you also had a fix to avoid passing None
as third argument or change the other lines... I apologize if you still want to open a PR.
from darkdetect.
EDIT: I did not realize you also had a fix to avoid passing
None
as third argument or change the other lines... I apologize if you still want to open a PR.
It's not a problem! I was just hacking at it to see how/why. Your solution seems much more elegant!
from darkdetect.
Ok, I will then proceed with tests (for what I can run, though, as I still do not own a M1 Mac :( ) and release this fix as soon as possible.
Once again, thanks for finding and debugging this issue. I wonder how this code had worked with x86_64 up to now...
from darkdetect.
Fixed in 0.5.0.
from darkdetect.
Yup! And live on pip
Successfully installed darkdetect-0.5.0
╭─ ~ ···································································· ✔ ─╮
╰─ ipython (napari-test) ─╯
Python 3.9.7 | packaged by conda-forge | (default, Sep 2 2021, 17:55:16)
Type 'copyright', 'credits' or 'license' for more information
IPython 7.25.0 -- An enhanced Interactive Python. Type '?' for help.
In [1]: import darkdetect
In [2]: darkdetect.theme()
Out[2]: 'Light'
<<<SWITCH TO DARK>>>
In [3]: darkdetect.theme()
Out[3]: 'Dark'
from darkdetect.
Works for both light and dark!
from darkdetect.
Related Issues (20)
- Crash on macOS Big Sur 11.4 HOT 19
- Check compatibility with Windows 11 HOT 7
- Listener for dark mode switch? HOT 11
- distutils.version LooseVersion is deprecated HOT 2
- Doesn't work for Pop!_OS 22.04 LTS x86_64 HOT 5
- Module produces ValueError on Windows 8.1 HOT 2
- Implement `listener` for macOS HOT 6
- correct dark detection for gtk3 HOT 19
- A way to terminate listener thread HOT 5
- [RFC] macOS code choices
- Listener class PR acceptable? HOT 3
- macOS listener support on apps where `sys.executable` is not a python interpreter HOT 8
- False positive HOT 1
- Issue: darkdetect listener cannot work under sudo HOT 2
- WARNING message from PyInstaller about ignoring AppKit.framework/AppKit imported from _mac_detect.py HOT 1
- Two Windows 'Dark' modes: `AppsUseLightTheme` and `SystemUsesLightTheme`
- ModuleNotFoundError: No module named 'darkdetect' in Python 3.8 HOT 2
- Duplicate
- Linux (GNOME) HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from darkdetect.