some codesniffer niceups about ontowiki HOT 11 CLOSED

yes please!

maybe we have different level here:
level 0:

• only hardcore errors do block the commit, including trying to commit into the master branch
• this is established with "make install" so its default
  level 1:
• our suggested level of quality checks, which is more accurate

btw: does make cs-install works on Darwin as well @pfrischmuth, maybe you can test that?

from ontowiki.

sorry, wrong button ... :)

from ontowiki.

additional requests:

• cs-install should test for root (to avoid errors)
• 2x cs-install crashes
• bad words: var_dump, exit; die, _POST, _GET, _REQUEST
• keine tabs
• no whitespaces at the end of the line

from ontowiki.

after working a little bit with the pre_commit hook, I would like to change that to pre_push if this exist:
the reason: implementing a feature and fixing the code quality should be different commits and I can't commit the feature first ...

what do you think about that?

from ontowiki.

@Lars: what about this issue? These additional requirements are important:

• cs-install should test for root (to avoid errors)
• 2x cs-install crashes
• test for bad words: var_dump, exit; die, _POST, _GET, _REQUEST
• test for tabs
• test for whitespaces at the end of the line

from ontowiki.

can we drop Internal.NoCodeFound errors on "make cs-check"

these errors appear on Makefiles, N3 files, ...

from ontowiki.

Seebi, the opening user was @larseidam not myself.

Thanks

from ontowiki.

@Lars: thanks ... and sorry :)

from ontowiki.

@ALL

now there is a CodeSniffer Update on commit 714ce22

Attention: some Makefile commands have changed (look at 'make help')

fixed issue:

• cs-install should test for root (to avoid errors)
• 2x cs-install crashes
• test for bad words: var_dump, exit; die, _POST, _GET, _REQUEST (also print_r and error_log)
• test for tabs
• test for whitespaces at the end of the line
• install CS on submodules/extensions
• run CS with specific sniffs

open issue:

• wikipage for sniff explanation
• CS integration for Vim
• forbid the committing in the master branch
• install CS on all submodules/extensions

@seebi

What do you mean with this??

can we drop Internal.NoCodeFound errors on "make cs-check"
these errors appear on Makefiles, N3 files, ...

Do you want a sniff that shows files they have no php code, files they are empty or something else??
Maybe we can talk about it on our meeting today.

from ontowiki.

lars, looks great!

regarding your question: I just dont want an error if the sniffer founds a file which is not php

one solution: the sniffer looks only for php and phtml files
another solution: it looks in every file but do not complain about files without php code

from ontowiki.

all issues in this thread are done or rather in a other Issus-thread

from ontowiki.