Response length not available at the time of logging (Tomcat) about logback-access-spring-boot-starter HOT 8 CLOSED

Maybe we could create a test that reproduces this error. Could you do it @akihyro ?

from logback-access-spring-boot-starter.

@adammichalik @fiunchinho Thanks for report.

I tried to make a test case.
When you release the following comment, an error will occur.

• https://github.com/akihyro/spring-boot-ext-logback-access/blob/f98fb3512142464180a54671902374b11bc253c9/src/test/java/net/rakugakibox/springbootext/logback/access/AbstractJsonAccessEventTest.java#L110
• https://github.com/akihyro/spring-boot-ext-logback-access/blob/f98fb3512142464180a54671902374b11bc253c9/src/test/java/net/rakugakibox/springbootext/logback/access/AbstractJsonAccessEventTest.java#L153

Maybe, when there is not HTTP response header "Content-Length",
the response length will not be logged (= -1).
Do you fit in this case? If this case, I'm going to try support!

[FYI] I was compared:

In the case of Logback-access:

• https://github.com/qos-ch/logback/blob/v_1.1.7/logback-access/src/main/java/ch/qos/logback/access/tomcat/LogbackValve.java#L258
• https://github.com/qos-ch/logback/blob/v_1.1.7/logback-access/src/main/java/ch/qos/logback/access/tomcat/TomcatServerAdapter.java#L39-L42

In the case of Spring Boot (server.tomcat.accesslog.enabled=true):

• https://github.com/spring-projects/spring-boot/blob/v1.3.3.RELEASE/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/web/ServerProperties.java#L832-L837
• https://github.com/apache/tomcat/blob/TOMCAT_8_0_0/java/org/apache/catalina/valves/AbstractAccessLogValve.java#L1129-L1151

from logback-access-spring-boot-starter.

Fixed the issue (PR: #5).

and, v1.2 has been released!
Please check the work with the v1.2.

http://search.maven.org/#artifactdetails%7Cnet.rakugakibox.springbootext%7Cspring-boot-ext-logback-access%7C1.2%7C

from logback-access-spring-boot-starter.

Thanks a lot for looking into it! I'm currently away from my computer for
the next week, so I'll check the details as soon as I can.
21 kwi 2016 18:27 "Akihiro Kondo" [email protected] napisał(a):

@adammichalik https://github.com/adammichalik @fiunchinho
https://github.com/fiunchinho Thanks for report.

I tried to make a test case.
When you release the following comment, an error will occur.

https://github.com/akihyro/spring-boot-ext-logback-access/blob/f98fb3512142464180a54671902374b11bc253c9/src/test/java/net/rakugakibox/springbootext/logback/access/AbstractJsonAccessEventTest.java#L110

https://github.com/akihyro/spring-boot-ext-logback-access/blob/f98fb3512142464180a54671902374b11bc253c9/src/test/java/net/rakugakibox/springbootext/logback/access/AbstractJsonAccessEventTest.java#L153

Maybe, when there is not HTTP response header "Content-Length",
the response length will not be logged (= -1).
Do you fit in this case? If this case, I'm going to try support!
[FYI] I was compared: In the case of Logback-access:

https://github.com/qos-ch/logback/blob/v_1.1.7/logback-access/src/main/java/ch/qos/logback/access/tomcat/LogbackValve.java#L258

https://github.com/qos-ch/logback/blob/v_1.1.7/logback-access/src/main/java/ch/qos/logback/access/tomcat/TomcatServerAdapter.java#L39-L42

In the case of Spring Boot (server.tomcat.accesslog.enabled=true):

https://github.com/spring-projects/spring-boot/blob/v1.3.3.RELEASE/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/web/ServerProperties.java#L832-L837

https://github.com/apache/tomcat/blob/TOMCAT_8_0_0/java/org/apache/catalina/valves/AbstractAccessLogValve.java#L1129-L1151

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#4 (comment)

from logback-access-spring-boot-starter.

Thanks, I tried it out and it works fine. Unfortunately, I found a new regression issue #8 which prevents me from upgrading.

from logback-access-spring-boot-starter.

Thanks a lot. The issue #8 was fixed! (PR: #10)

from logback-access-spring-boot-starter.

Works fine in 1.3, thanks!

from logback-access-spring-boot-starter.

Thanks a lot for checking!

from logback-access-spring-boot-starter.