Git Product home page Git Product logo

Comments (5)

OnurGumus avatar OnurGumus commented on June 3, 2024

I suspect this line should be moved above on top of the method

await _journal.InitializeTables(_pendingWriteCts.Token);

from akka.persistence.sql.

to11mtm avatar to11mtm commented on June 3, 2024

Two questions for @Aaronontheweb and @Arkatufus:

  1. Should we be auto-initializing Journals from the Query Side?
  2. If Yes, should we have that as a separate config option?

from akka.persistence.sql.

Arkatufus avatar Arkatufus commented on June 3, 2024

There are problems implementing database table initializer for the read journal.

In the old Sql.Common implementation, all table operations (both read and write) were implemented inside the journal actor, this allows for command stashing for all operations, allowing the journal to complete any database initialization before processing any database operations.

In Akka.Persistence.Sql, the read journal accesses the database directly, giving it a performance boost. The problem with this design is that there's no mechanism we can tap into to make sure that the database tables are initialized.

from akka.persistence.sql.

OnurGumus avatar OnurGumus commented on June 3, 2024

I understand the challenges how ever I don't agree with the outcome at least the exception should be handled in someway. Please reopen @Aaronontheweb @Arkatufus

from akka.persistence.sql.

Aaronontheweb avatar Aaronontheweb commented on June 3, 2024

Fair point, we should handle the exception at least

from akka.persistence.sql.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.