Comments (9)
Good to see you here @ilke-zilci!
from akka-http.
Hey, I'd like to take this one, is anyone working on it already?
from akka-http.
No, seems no one has picked it up yet, thanks for looking into it! :)
(Feel free to ask if not sure about things with it etc)
from akka-http.
I agree, might be a good starting contribution!
However, I find the ticket description a bit unclear. I think it's about using parameter("age".as(xyzUnmarshaller))
and this xyzUnmarshaller
throws an exception? Do you remember if that was the case here, @ktoso?
In that case, this code here seems to convert the exception into a rejection: https://github.com/akka/akka-http/blob/master/akka-http/src/main/scala/akka/http/scaladsl/server/directives/ParameterDirectives.scala#L115
It should probably be documented in the documentation of the parameters
directive here: https://github.com/akka/akka-http/blob/master/docs/src/main/paradox/scala/http/routing-dsl/directives/parameter-directives/parameters.md
from akka-http.
Yes, it was about that; AFAIR someone expected "well it's an exception so should be an error page!", but indeed there we interpret it as "well, unable to extract, let's try another one", so as a rejection :)
from akka-http.
Great! I will work on it then. It goes here, right? https://github.com/akka/akka-http/blob/master/docs/src/main/paradox/scala/http/routing-dsl/rejections.md
from akka-http.
As @jrudolph mentioned, I would document it next to the Path Parameter documentation pages (https://github.com/akka/akka-http/blob/master/docs/src/main/paradox/scala/http/routing-dsl/directives/parameter-directives/parameters.md) and then link to the rejection doc page as a "see for further info".
And don't forget to document it for both Scala and Java docs :)
from akka-http.
Ok thanks. And sorry missed that line on the first read.
from akka-http.
Fixed in #1285.
from akka-http.
Related Issues (20)
- Cannot Unmarshall Seq[String] Outside HOT 1
- Release 10.6.0-M1
- Release 10.6.0-M2
- CVE-2023-44487 HOT 3
- Release 10.5.3
- Release 10.6.0
- Failed: Http2ClientSpec should send RST_STREAM if entity stream is canceled HOT 2
- Failed: Http2ServerSpec send RST_STREAM if entity stream is canceled
- Remove dependency on `sbt-dependency-graph` HOT 1
- Release 10.6.1
- Failed: Native image tests HOT 1
- SSE (and maybe more) marshalling/unmarshalling require classic system HOT 1
- fail: CI is failing to publish docs HOT 2
- The akka.http.cors package is not exist HOT 1
- Release 10.6.2
- failed: JwtDirectivesSpec HOT 4
- Failed: OutOfMemoryError HOT 1
- Release 10.6.3 HOT 1
- Explicit typed actor system to Http.apply does not compile on Scala 3
- `Content-Disposition` header parsing for `form-data` doesn't follow RFC7578 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from akka-http.