Airbrake throws away information for incompatible backtraces about airbrake-ruby HOT 11 CLOSED

My suggestion would be to not raise in these cases, but return a dummy hash, something like:

{ file: nil, line: nil, function: stackframe }

from airbrake-ruby.

Hey there @martinvium!
Thanks for the report. I think we should try to parse it since it contains line numbers useful for grouping and the format seems to be well-defined. When the library raises, it prints what it can't parse, so it helps adding support for new backtrace formats.

from airbrake-ruby.

Completely up to you if you want to support Oracle directly, that would be great. Even then, i think there should be a reasonable fallback, since you might not know what other types of formats might exist out there and it's really hard to debug (until you know what the problem is).

from airbrake-ruby.

True, but if we don't raise, how would we know we don't support something? :)

from airbrake-ruby.

You could flag it in the notice? raw_backtrace: true

from airbrake-ruby.

Really it was painful to debug, and took me a while to realize it was a general problem and not just a special case, then figure out that it was not a problem with either of the Oracle gems, then on the various other middleware. Finally Google told me about above PR, which i eventually realized was triggering the behaviour (in between lots of trial and error to see what the "true" output was of manually triggering the stored procedure).

from airbrake-ruby.

I'd like to clarify: was it hard to find the root of the error because of the confusing error message or because of the nature of stored procedures (that is, you didn't have access or couldn't see the error in the first place)?

from airbrake-ruby.

It was hard to debug the original problem, because Airbrake only showed the last (and really not relevant) line of the error:

from stmt.c:243:in oci8lib_220.bundle

Hiding all the interesting stuff:

OCIError: ORA-02291: integrity constraint (STORE.SN_PACE_REGISTRATIONS_FK01) violated - parent key not found
ORA-06512: at "STORE.LI_LICENSES_PACK", line 1945
ORA-06512: at "ACTIVATION.LI_ACT_LICENSES_PACK", line 101
ORA-06512: at line 2

It was also hard to figure out that Airbrake was at "fault", and that i needed to downgrade to fix it.

from airbrake-ruby.

Also the entire backtrace was obfuscated, because this is an "error" in Airbrake, i don't see the original stacktrace e.g. which controller was triggering it, only the Airbrake middleware backtrace.

from airbrake-ruby.

Thanks for the bug report again and your feedback! Now the library won't crash on unsupported stack frames and log them instead.

from airbrake-ruby.

Thank you very much for the quick response and fix! Much appreciated, will give it a spin next week.

from airbrake-ruby.