Subscriptions need to happen in `onCreate`. about mavericks HOT 13 CLOSED

No, I don't think so, as the subscriptions would be disposed in onDestroyView so they can be safely recreated in onCreateView.

from mavericks.

@BenSchwab Yeah, makes sense. Want to take a stab at it?

from mavericks.

Sometimes having all subscriptions in onCreate is really annoying since views have not been created here which means everything used in the callback need to be a member of the fragment instead of a local variable. And it's also error prone cuz this is not guaranteed by any compile-time checking .

Why not try using getViewLifecycleOwner instead of this for a fragment? This only requires upgrading support library version to 28.

from mavericks.

@justsosoxd That should be okay because the subscription will only get called when the fragment is in the STARTED lifecycle.

from mavericks.

@BenSchwab What is actionable here?

from mavericks.

@justsosoxd wouldn't using getViewLifecycleOwner() possibly make things even worse? The view lifecycle can be even shorter in case of detached Fragments than the one of the Fragment itself as per the documentation.

from mavericks.

@gpeal We could start logging a warning (or crash) if you subscribe after onCreate? Or maybe we could keep a list of active subscribers references and no-op if one already exists? (I would need to look into how references work on lambdas, not sure if this is possible.)

from mavericks.

@ubuntudroid If I get it right, the problem we need to solve here is duplicated subscription when fragments are added to backstack then resumed. view lifecycle can avoid this problem as the subscription will be canceled when fragment is added to backstack. why would it make things worse?

from mavericks.

@justsosoxd uh, I think I got the problem statement wrong. After rereading I think you are actually right. Sorry for the confusion!

from mavericks.

@BenSchwab True, we could check lifecycle state and make sure that it equals CREATED.

from mavericks.

@BenSchwab What do we want to do here?

from mavericks.

I think we can change subscriptions made after onCreate to use getViewLifecycleOwner .

Need to add tests, but this is what it would look like: b76d71b

from mavericks.

@BenSchwab How would using the view lifecycle owner solve this? Wouldn't you still have duplicate subscriptions?

from mavericks.