Git Product home page Git Product logo

Comments (8)

bryankeller avatar bryankeller commented on June 29, 2024 9

Thanks for filing @Elshad - we've encountered this too at Airbnb, and it seems like it's a UICollectionViewLayout bug (we also reproduced it using flow layout).

I wonder if there's a way to work with the contentOffsetAdjustment behavior at scroll time to mitigate this. I'll dig a bit more. Worst case scenario, we'll file a radar. Give me a few days to play around with some ideas and I'll post back here with any findings / radars.

from magazinelayout.

bryankeller avatar bryankeller commented on June 29, 2024 1

@Elshad this is now fixed in
https://github.com/airbnb/MagazineLayout/releases/tag/v1.0.1. The PR that fixes it is
#11

from magazinelayout.

AamirAnwar avatar AamirAnwar commented on June 29, 2024

@bryankeller Jumps when there aren't those many items too :(
Any workarounds for this?
screenrecording_12-27-2018 21-58-50

from magazinelayout.

bryankeller avatar bryankeller commented on June 29, 2024

@AamirAnwar that looks like a separate issue from the rotation one that was originally posted. Can you file a separate issue with that GIF and any other details? Thanks!

from magazinelayout.

diegorozen avatar diegorozen commented on June 29, 2024

@bryankeller Has the podspec being pushed to Trunk. I still see last version as 1.0

from magazinelayout.

bryankeller avatar bryankeller commented on June 29, 2024

@diegorozen whoops, thanks for catching that! It should be updated now ๐Ÿ™‚

from magazinelayout.

haydgately avatar haydgately commented on June 29, 2024

Still seeing this self sizing issue on v1.4.3 if I:
-Scroll down in the collection view smoothly.
-Push another view controller onto the navigation stack.
-Pop the view controller back to collection view.
-Scroll up and see scrolling is choppy.

I see this was closed but this became a bug about the rotational issue which my issue isn't convinced with. @bryankeller

from magazinelayout.

bryankeller avatar bryankeller commented on June 29, 2024

@haydgately thanks for the information. It seems odd to me that pushing a completely independent view controller, then popping it, would affect anything in the initial view controllerโ€™s collection view. What are you doing in viewWill/DidAppear? Are you reloading data or invalidating the layout?

Do you have a sample project / setup to repro? Any additional information you can provide will be very much appreciated ๐Ÿ™‚ And if you think the issue is actually different from this one, feel free to open a new issue.

from magazinelayout.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.