Comments (8)
Thanks for filing @Elshad - we've encountered this too at Airbnb, and it seems like it's a UICollectionViewLayout
bug (we also reproduced it using flow layout).
I wonder if there's a way to work with the contentOffsetAdjustment
behavior at scroll time to mitigate this. I'll dig a bit more. Worst case scenario, we'll file a radar. Give me a few days to play around with some ideas and I'll post back here with any findings / radars.
from magazinelayout.
@Elshad this is now fixed in
https://github.com/airbnb/MagazineLayout/releases/tag/v1.0.1. The PR that fixes it is
#11
from magazinelayout.
@bryankeller Jumps when there aren't those many items too :(
Any workarounds for this?
from magazinelayout.
@AamirAnwar that looks like a separate issue from the rotation one that was originally posted. Can you file a separate issue with that GIF and any other details? Thanks!
from magazinelayout.
@bryankeller Has the podspec being pushed to Trunk. I still see last version as 1.0
from magazinelayout.
@diegorozen whoops, thanks for catching that! It should be updated now ๐
from magazinelayout.
Still seeing this self sizing issue on v1.4.3 if I:
-Scroll down in the collection view smoothly.
-Push another view controller onto the navigation stack.
-Pop the view controller back to collection view.
-Scroll up and see scrolling is choppy.
I see this was closed but this became a bug about the rotational issue which my issue isn't convinced with. @bryankeller
from magazinelayout.
@haydgately thanks for the information. It seems odd to me that pushing a completely independent view controller, then popping it, would affect anything in the initial view controllerโs collection view. What are you doing in viewWill/DidAppear? Are you reloading data or invalidating the layout?
Do you have a sample project / setup to repro? Any additional information you can provide will be very much appreciated ๐ And if you think the issue is actually different from this one, feel free to open a new issue.
from magazinelayout.
Related Issues (20)
- Layout constraints are breaking when aspect ratio on UIImageView is set HOT 1
- Podspec swift version must be updated.
- Swift 5.1 support. HOT 2
- Why MagazineLayoutCollectionViewLayoutAttributes is `final`? HOT 3
- Scrolling to item when using dynamic cell height HOT 1
- UIKit layout issues with square collection cells HOT 5
- Alignment bug on simultaneous insertion and refresh
- cell height equal with width HOT 2
- Could not dequeue a view of kind --- Delegate mixing Header, Footer and Background
- Waterfall HOT 1
- `layoutAttributesForItem(at:)` crashes when given an empty index path HOT 6
- Animating header resize HOT 5
- Waterfall (pinterest-like) layout HOT 1
- iOS 12 Compatibility? HOT 5
- Crash when adding and deleting items using `RxDataSource` HOT 2
- Could you add a function that adds y-axis offset to the hover head?
- Could you add a function that adds y-axis offset to the hover head? HOT 1
- Header and Footer are not visible during the section insertion animation HOT 1
- SPM support HOT 1
- Is it Possible to Dynamic Pintrest layout? HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from magazinelayout.