Comments (6)
@davidxiasc I think it's best to file a new issue here. If you do file a new issue, it would be exceedingly helpful to get a sense of:
- What have you tried
- What did you expect to happen
- What happened
If you want to go above and beyond in your new issue: fork this repo and point us at a branch that shows the issue you're seeing (this isn't required, but will make it way easier/quicker for us to help). Please also include in your issue why you're putting code directly in the binary so we can better understand your use case.
All that said: I pretty strongly advise you to wrap your code in a library, and have your binary depend on the library (as we do here). As far as I can tell, putting code directly in the binary has little-to-no benefit, but it comes with plenty of downsides: all of a sudden you need bridging headers, the name of the binary rule might change between debug and release which changes your module name and can break storyboards, you can't @testable
import your binary target, etc.
Note that given the above, we're unlikely to want to merge in an example to master
that shows how to accomplish what you're asking. But I'm always curious what folks' use cases are, and I'm happy to help if I can.
from bucksample.
@nebillo The mixed language support is not working in master branch yet.
You can try with our open source branch which should work:
https://github.com/airbnb/buck/tree/airbnb-modular-external-use
More details can be found here:
https://github.com/airbnb/BuckSample/blob/master/README.md
We are working on merge our changes upstream but haven't finish yet.
from bucksample.
@zayhero Any updates on getting this work pushed upstream?
from bucksample.
We're working on it. Currently the only bit we need to diverge from Facebook's master
is facebook/buck#2163. If you use that branch, you should be good to go.
I'm going to close this issue out, since we have -Swift.h
imports working in this repo, and have demonstrated it with #35.
from bucksample.
sorry to bump this issue, but I'm trying to get -Swift.h
imports work inside an apple_binary as opposed to an apple_library. Would you have any guidance on how to accomplish this? We have Defines Module
and Module Name
defined in the Xcode project, but its unclear how that translates into flags
from bucksample.
@dfed thanks, continuing in #107
from bucksample.
Related Issues (20)
- Update CI to Xcode 10 HOT 8
- Issues with importing *-Swift.h in an apple_binary() HOT 4
- XCode 11 issues with `UICollectionViewDiffableDataSourceCellProvider` HOT 1
- [Feature Request] Basic build caching on CI
- Running Buck on 32bit simulators HOT 5
- Running on iPhone X or higher (arm64e) HOT 2
- Question about Embedded Binaries (Carthage frameworks) in generated Xcode workspace HOT 2
- [Question] Local build time with Xcode project HOT 2
- [Question] How to deal with resources/localization keys?
- Tests take 15 seconds to run, if run individually HOT 9
- [Question] How to know when a test result is cached? HOT 4
- Running `make test` fails with Xcode 11.1 HOT 4
- Precompiled Library Issue (no such module) HOT 2
- Modify Swift method implementation shouldn't cause rebuilding its dependents HOT 2
- Add example of App Clip HOT 1
- make test meeting some mistake
- Get Hosted App testing working and reenable it
- linker flags error in cxx_library and "-I $(location //targets:myrule)" preprocessor flags
- Is it supported on Linux?
- [PSA] Airbnb iOS has migrated to Bazel
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bucksample.