Add SASL Plain support about aiokafka HOT 6 CLOSED

Hi, I forked the repository to work on this feature. I hope we'll have something in a few days :) .

EDIT: In fact, I'll add only partial support (SASL_PLAINTEXT + SCRAM-SHA-256).

from aiokafka.

Would really like to see it implemented in an async fashion :)
Is this planned for a next future ? If not, could you point out where and how it could be implemented, so I might dive in this feature ?

from aiokafka.

@cyrbil I'm sorry, our prioritization changed and I had to stop developing that feature :( .

from aiokafka.

#386
@cyrbil @tvoinarovskyi

Seems like I got these patches working with the latest master with some caveats :

Consumer:

• In the beginning I do get a bunch of failed authentications after which it succeeds.
• If the connection fails at some point, reconnecting fails (and from short testing, it always fails at some point),
• If a consumer cannot find a topic on the broker, it attempts to create that topic which in turn requires permissions to create topics and if the consumer doesn't have those permissions, the consumer is left in an reconnect loop with no apparent reason as to why it's failing. Not sure why the consumer tries to create the non-existing topic, but that might be because I have automatic creation of topics enabled on the broker(s).

Producer:

• After adding SASL related arguments to the AIOKafkaProducer class, rudimentary testing shows that producing works with no bigger problems. Same as with the consumer, in the beginning there's a failed authentication (broker response being Error 33).

Kafka broker version: 2.0
Python: 3.6.6

from aiokafka.

Plan to work on this in Q1 of 2019. Sorry for the trouble, but #386 is only a part of what needs to be done, as you can see from @fisuk comment. Will need to add proper handling for all Authorization errors on Consumer, Producer, etc. For example GroupAuthorization, TopicAuthorization, etc.
Also, I feel like I don't want this not covered by tests. Kerberos is a troublesome one to set up for testing. Hope I can find some easy container setup to use. Still requires quite some effort to cover all errors and permission combinations.

from aiokafka.

Protocol changes in #464 should be good now. Will need to work on all exception handling in Producer and Consumer.

from aiokafka.