Git Product home page Git Product logo

Comments (4)

Dreamsorcerer avatar Dreamsorcerer commented on May 18, 2024

Currently, it looks like the only way to use the async functionality is like this:

template = aiohttp_jinja2.get_env(request.app).get_template("index.jinja")
return web.Response(text=await template.render_async(), content_type="text/html")

from aiohttp-jinja2.

Dreamsorcerer avatar Dreamsorcerer commented on May 18, 2024

Given that passing enable_async breaks the existing functions, maybe a good way to handle backwards compatibility is just to switch the functions when enable_async is passed by the user.

e.g.

if kwargs.get("enable_async", False):
    aiohttp_jinja2.template = aiohttp_jinja2._template_async
    aiohttp_jinja2.render_template = aiohttp_jinja2._render_template_async

Or, something like that. Then all the user has to do is add enable_async=True to the setup() call.

from aiohttp-jinja2.

Dreamsorcerer avatar Dreamsorcerer commented on May 18, 2024

@asvetlov I'm happy to work on this PR. Any thoughts on the correct way to implement it? Does my last comment seem reasonable?

from aiohttp-jinja2.

asvetlov avatar asvetlov commented on May 18, 2024

I think we need separate functions for async mode.

If you are willing to work on it -- please go ahead

from aiohttp-jinja2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.