runserver is confusing about aiohttp-devtools HOT 4 CLOSED

Have you written unit tests yet?

aiohttp-devtools assumes a function which takes loop as an argument so you can easily write tests that use that function. All the test fixture stuff for pytest (much the easiest way of writing tests for aiohttp code) creates a new event loop for every test (or at least every async def test, which accounts for 99% of aiohttp application tests) and explicitly removes the default loop so you're forced to use the loop which is created for the test and pass a reference to that loop around.

That said, it wouldn't be too hard (as far as i can see right now with a stinking hangover) to modify runserver to accept an app instance instead of a method, however I would still recommend using a function with signature def create_app(loop): -> app to make testing easier.

from aiohttp-devtools.

Should be fixed in #36, @szastupov please review and let me know if you think that's easier.

Looking back on this I think part of the reason app_factory had to be a method with that signature was to make testing aiohttp-devtools easier which is clearly the tail wagging the dog.

from aiohttp-devtools.

Yeah, works as expected 👍 Thanks a lot 🙏

from aiohttp-devtools.

new version 0.2 deployed with the fix.

from aiohttp-devtools.