Git Product home page Git Product logo

Comments (3)

aimeos avatar aimeos commented on May 21, 2024

Thank you very much! We hope you love Aimeos as much as we do :-)
Can you create a PR for setting the compression quality correctly?

The documentation is correct (['image']['jpeg']['quality']):

array(
	'image' => array(
		'name' => 'Imagick',
		'jpeg' => array(
			'quality' => 100
		),
	)
)

from aimeos-core.

nvindice avatar nvindice commented on May 21, 2024

Thanks, PR is created.

Still, I am not sure if the documentation is correct. Please check line 71 in the file mentioned above, the code says:

if( isset( $this->options['image']['quality'] ) ) {
	$quality = max( min( (int) $this->options['image']['quality'], 100 ), 0 );
}

I tested to set the image quality in Typo3 configuration as following and it works (tested w/ debugging exceptions):

module.tx_aimeos.settings.controller.common.media.standard.options {
  image {
    name = Imagick
    quality = 100
  }
}

Setting the quality parameter inside the jpeg array did not work as expected for me.

Thank you for this great product and all your efforts!

from aimeos-core.

aimeos avatar aimeos commented on May 21, 2024

You are right, the quality parameter isn't distinguished by the file type any more. It's now fixed in the code and documentation will be updated with the next release:

https://github.com/aimeos/aimeos-core/blob/master/controller/common/src/Controller/Common/Media/Standard.php#L270

from aimeos-core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.