Git Product home page Git Product logo

Comments (4)

sphuber avatar sphuber commented on August 16, 2024

This was discussed in the PR that changed it. As you can see, the original proposed string was SuRe which I opposed. I am personally also simply for [y/N] (the capitalizad N is just to show that that is the default I believe). We compromised and settled on yes/N as @khsrali @GeigerJ2 and @giovannipizzi thought it dangerous to keep just y.

from aiida-core.

GeigerJ2 avatar GeigerJ2 commented on August 16, 2024

So the idea here was that deleting a computer doesn't only delete the isolated computer. To keep provenance, it also deletes all the connected nodes, so all processes of a user that were run on this computer. So it's an operation that should only be done with great care. Personally, I'd also be fine with [y/N] as that is usually the standard. The fear was that people just quickly pressing through things might accidentally run the operation somewhat unintentional, though, that should be captured with [y/N]. Don't really have a strong opinion on the topic, for me either is fine. Ideally, as always, I'd vouch for consistency.

from aiida-core.

giovannipizzi avatar giovannipizzi commented on August 16, 2024

I'm ok with the original suggestion and generally keeping a consistent style across verdi commands, as long as the default stays N

from aiida-core.

khsrali avatar khsrali commented on August 16, 2024

We thought perhaps using a different response than the usual "y" would make sense to prevent accidental data loss.
As @sphuber said, we compromised to "yes". But if @agoscinski thinks that is confusing regarding standardization, one could replace with "please type: 'confirm deletion' ", like when github asks you when deleting your repo.
This way remain both safe and standard.

from aiida-core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.