Git Product home page Git Product logo

Comments (2)

mikibonacci avatar mikibonacci commented on September 1, 2024

yes, for now I have not deleted direct attributes like cell, pbc and so on, which are of the old StructureData. But this are no more working and are not related to the properties. I just left them there because I am not sure we really want to put everything under the properties attribute. In that case, the true structuredata node will be contained in the properties attribute, and nothing else is left outside (apart the Data methods)

from aiida-atomistic.

mbercx avatar mbercx commented on September 1, 2024

I just left them there because I am not sure we really want to put everything under the properties attribute. In that case, the true structuredata node will be contained in the properties attribute, and nothing else is left outside (apart the Data methods)

Yes, this is also an observation I was making, and would make certain operations more cumbersome than they have to be. My first inclination is that I would really like to have structure.cell. But then if we treat all properties equally, all of them should have a corresponding attribute. And maybe that's ok, but then what's the point of the properties namespace?

I'm not even considering the implementation here. Just the API.

from aiida-atomistic.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.