Git Product home page Git Product logo

Comments (3)

BruceYanghy avatar BruceYanghy commented on May 27, 2024

First, thank you for this awesome project.

I try to add some leaky features to the model to see if it is capable of exploiting that kind of features. Normally I would expect to see some incredible result, because basically I'm telling the future to the model. But; model still works poorly. Why would that be you think? Is it maybe because of parameters of the model?

Also, in some models I see that, in some iterations rewards became 0 with these leaky features. So, some models choose not the operate instead of exploit these future information.

Thanks.

Good idea, what are the leaky features?

from finrl.

Bturan19 avatar Bturan19 commented on May 27, 2024

@BruceYanghy first of all I changed 'daily_return' to this:
df.close.shift(-10).pct_change(1).rolling(10).mean().fillna(0)
and also created similar features and finally added local minimum and maximum points. All these features can not be known in the present time.

Local minimum and maximum informations are extreme leakeage features. Even if you implement so much simple trading strategy it would make great impact (but it can not be known). I would expect the RL model to exploit these.

from finrl.

YangletLiu avatar YangletLiu commented on May 27, 2024

Thanks for you suggestions!

from finrl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.