Git Product home page Git Product logo

Comments (4)

Chawanvit avatar Chawanvit commented on August 15, 2024

I think you need to change parameter named "STOCK_DIM" which is total number of stocks in our portfolio in Env train, validation,trade files.

from finrl-trading.

qingzew avatar qingzew commented on August 15, 2024

I don't think so, in this repo all stocks in STOCK_DIM form a stock portfolio, in other words, after a prediction, people must do every ops(sell, buy, nothing) according to prediction result, but if I have STOCK_DIM=3000, I can't buy all of them, it may need a lot of money.

from finrl-trading.

emjay032 avatar emjay032 commented on August 15, 2024

From my point of view buy and sell actions are ranked according to the ammount to buy at each time step. So you are right if you have 3000 stocks in your action space hence possibly buy every stock of the 3000 then it can happen that not every stock is bought because the buy function is intitialized in a for loop and the actions are sorted according to the amount to buy maybe you should increase the intitial account balance from 100.000 to a higher amount or lower the HMAX parameter to control the rescaling of the actions because the PPO/A2C... rely on a gaussian distribution and are scaled to [-1,1]
you can also verify this by creating a variable (buy_activity/sell_activity) which is returend after testing to track the stocks bought and sold at each time step
just modifiy the testing environment if you want i can help you

from finrl-trading.

qingzew avatar qingzew commented on August 15, 2024

@emjay032 thank you, I'm trying to another method, that is every stock is one episode even in environment, so one episode is done, another one again, I'm doing it

from finrl-trading.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.