Git Product home page Git Product logo

Comments (9)

ai avatar ai commented on June 17, 2024 1

If you don’t have time, I will find another developer to do it, it is not a problem (your idea is good, that is the main step here)

from size-limit.

ai avatar ai commented on June 17, 2024

I like the idea. Do you want to send PR?

from size-limit.

piranna avatar piranna commented on June 17, 2024

It was my idea, but was not able to find the exact point where I should do it, that's why I opened the issue instead. If you could be able to point me to the place, I'll happily do the pull-request :-)

from size-limit.

ai avatar ai commented on June 17, 2024
  1. You need to fix config validator https://github.com/ai/size-limit/blob/master/cli.js#L105-L121
  2. Somewhere here you need to set entry.full to [resolve(packageJson.main)] if entry.path is missed https://github.com/ai/size-limit/blob/master/cli.js#L246-L270
  3. You need to update docs https://github.com/ai/size-limit/blob/master/README.md#config
  4. Add path-less case here https://github.com/ai/size-limit/tree/master/test/fixtures and test it in https://github.com/ai/size-limit/blob/master/test/cli.test.js
  5. Maybe update config validation tests

from size-limit.

piranna avatar piranna commented on June 17, 2024

It's ok if any other wants to work on this :-)

from size-limit.

ai avatar ai commented on June 17, 2024

Done 326a890

from size-limit.

ai avatar ai commented on June 17, 2024

I will wait #71 before releasing it

from size-limit.

ai avatar ai commented on June 17, 2024

Released in 0.20

from size-limit.

piranna avatar piranna commented on June 17, 2024

Thank you! :-)

from size-limit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.