Git Product home page Git Product logo

Comments (11)

ai avatar ai commented on June 23, 2024 1

@mflores-verys sorry for the long delay. Had hard times because of the conference.

I wanted to confirm, does that option exist today or are you suggesting this would be a good capability for someone to add via PR?

Size Limit doesn’t have this option.

If you want to send PR, I will help you and accept it.

from size-limit.

ai avatar ai commented on June 23, 2024

Do I understand correctly that you want --why with custom webpack config?

In this case, just add Webpack Bundle Analyzer to your custom config.

Maybe we can do it automatically? Like changing webpack config in Size Limit. Do you want to send PR? (I am preparing for the conference and will be able to do it only in next week).

from size-limit.

jeffredodd avatar jeffredodd commented on June 23, 2024

I guess i'm trying to understand where the build is being stored. If I could customize it using CLI I could then store it using CircleCI to define temp folders which are copied into my artifacts.

See documentation here. https://circleci.com/docs/2.0/artifacts/

I can try to get a PR up this weekend if this is something that would be useful for other consumers as well. πŸ˜„

from size-limit.

ai avatar ai commented on June 23, 2024

@jeffredodd Size Limit builds a project in memory. So you will not find it on the disk. Why do you need to find it?

from size-limit.

jeffredodd avatar jeffredodd commented on June 23, 2024

@ai The purpose of this is to store the information on a per build basis. I work in a repository that receives a lot of internal contributions daily and we store our test coverage data in artifacts so we have a historical reference to the values at build time. This helps us during investigations say on why test coverage decreased, when, why it happened, etc.

We are hoping to do the same thing with SizeLimit, and by storing the output of --why would allow us to browse this information historical using the same tools versus pulling down a specific commit number and running it locally.

from size-limit.

ai avatar ai commented on June 23, 2024

@jeffredodd Got it. Do you want to store total bundle size or you want to store the whole --why tree?

from size-limit.

jeffredodd avatar jeffredodd commented on June 23, 2024

Usually we store the whole webpack bundle or --why tree. I'll try to take a stab at it this weekend! Your feedback will be appreciated πŸ˜„.

from size-limit.

ai avatar ai commented on June 23, 2024

There are 2 options:

  1. You use custom webpack config, add Webpack Bundle Analyzer there with custom callback with stats data.
  2. You can add --why-stats path/to/file/to/save/stats option to Size Limit

from size-limit.

ai avatar ai commented on June 23, 2024

Do you have custom webpack config right now?

from size-limit.

eps1lon avatar eps1lon commented on June 23, 2024

@jeffredodd Sorry to bother you here but I didn't find any other way to contact you: What's your experience so far with using build artifacts for historical data?

The circle CI documentation says that there is no guarantee about storage duration and that artifacts should only be used around build time. I would like to use build artifacts for historical analysis of our builds but the statements on the documentation lead me to believe that they're not appropriate for those things.

There is a 3GB curl file size limit. Artifacts are designed to be useful around the time of the build. It is best practice not to rely on artifacts as a software distribution mechanism with long term future guarantees.
-- https://circleci.com/docs/2.0/artifacts/#artifacts-overview

from size-limit.

mflores-verys avatar mflores-verys commented on June 23, 2024

@ai

You can add --why-stats path/to/file/to/save/stats option to Size Limit

I wanted to confirm, does that option exist today or are you suggesting this would be a good capability for someone to add via PR?

from size-limit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.